Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks for VG and Pod existence when creating volume #58857

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Add checks for VG and Pod existence when creating volume #58857

merged 1 commit into from
Jul 18, 2019

Conversation

sdodsley
Copy link
Contributor

@sdodsley sdodsley commented Jul 9, 2019

SUMMARY

Add checks to ensure a volume group or pod exists when a volume name specifies creation in
a pod or volume group

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

purefa_volume

ADDITIONAL INFORMATION

If a volume name is specified with the syntax pod::name or group/name then the volume will be
created and automatically added into the pod or volume group specified.
This patch ensures the pod or volume group actually exists before the creation attempt is made.

@ansibot
Copy link
Contributor

ansibot commented Jul 9, 2019

cc @bannaych @genegr @lionmax @opslounge @raekins @sile16
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. pure_storage storage support:community This issue/PR relates to code supported by the Ansible community. labels Jul 9, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 17, 2019
@genegr
Copy link

genegr commented Jul 18, 2019

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core automerge This PR was automatically merged by ansibot. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 18, 2019
@ansibot ansibot merged commit 4acbb83 into ansible:devel Jul 18, 2019
@ansible ansible locked and limited conversation to collaborators Aug 15, 2019
@sdodsley sdodsley deleted the purefa_vol_enhance branch August 28, 2019 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. pure_storage shipit This PR is ready to be merged by Core storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sdodsley @ansibot @genegr