Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument vlanid (int) is changed internally to string #58963

Merged
merged 4 commits into from
Jul 11, 2019
Merged

Argument vlanid (int) is changed internally to string #58963

merged 4 commits into from
Jul 11, 2019

Conversation

pratikgadiya12
Copy link
Contributor

SUMMARY

TypeError: argument of type 'int' is not iterable, as vlanid (int) is not changed into a string

Fixes: #58949

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/net_tools/nmcli.py

@ansibot
Copy link
Contributor

ansibot commented Jul 11, 2019

cc @alcamie101
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jul 11, 2019
@pratikgadiya12 pratikgadiya12 mentioned this pull request Jul 11, 2019
Closed
@Akasurde
Copy link
Member

@pratikgadiya12 Thanks for a quick response. Could you please add test case for this change here? Thanks.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 11, 2019
@pratikgadiya12
Copy link
Contributor Author

@pratikgadiya12 Thanks for a quick response. Could you please add test case for this change here? Thanks.

Done

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 11, 2019
@Akasurde Akasurde merged commit e8f4ebb into ansible:devel Jul 11, 2019
@Akasurde
Copy link
Member

@pratikgadiya12 Thanks for the contribution.

pratikgadiya12 added a commit to pratikgadiya12/ansible that referenced this pull request Jul 11, 2019
@pratikgadiya12
nmcli: Argument vlanid (int) is changed internally to string (ansible…
a15c500 
…#58963)

* Argument vlanid (int) is changed internally to string
* Modified test case to check vlan id

Fixes: ansible#58949
(cherry picked from commit e8f4ebb)
abadger pushed a commit that referenced this pull request Jul 17, 2019
@pratikgadiya12 @abadger
nmcli: Argument vlanid (int) is changed internally to string (#58963)
0f292cd 
* Argument vlanid (int) is changed internally to string
* Modified test case to check vlan id

Fixes: #58949
(cherry picked from commit e8f4ebb)
@ansible ansible locked and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: argument of type 'int' is not iterable, as vlanid (int) is not changed into string
3 participants
@pratikgadiya12 @ansibot @Akasurde