Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_dns_client - fix bug in devel and added tests #58971

Merged
merged 2 commits into from
Jul 11, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

A small bug introduced with #55862 has broken win_dns_client on older Windows hosts due to the change from the WMI to CIM cmdlets. This PR fixes that bug and also adds tests to hopefully pick up issues in the future before they are merged.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_dns_client

@ansibot
Copy link
Contributor

ansibot commented Jul 11, 2019

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Jul 11, 2019
@jborean93 jborean93 merged commit bcc23e7 into ansible:devel Jul 11, 2019
@jborean93 jborean93 deleted the win_dns_client-test branch July 11, 2019 19:36
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Jul 11, 2019
@ansible ansible locked and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants