Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix strat inv #58982

Merged
merged 3 commits into from
Jul 11, 2019
Merged

Fix strat inv #58982

merged 3 commits into from
Jul 11, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jul 11, 2019 •
edited

Update strategy inventory update functions to use corrected group name

fixes #58980

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

strategy

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 11, 2019
jamescassell
jamescassell approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@jamescassell jamescassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd like to see a test also with ANSIBLE_TRANSFORM_INVALID_GROUP_CHARS=never

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 11, 2019
jamescassell
jamescassell approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@jamescassell jamescassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@bcoca bcoca merged commit a7b14ec into ansible:devel Jul 11, 2019
@bcoca bcoca deleted the fix_strat_inv branch July 11, 2019 17:50
bcoca added a commit to bcoca/ansible that referenced this pull request Jul 11, 2019
@bcoca
Fix strat inv (ansible#58982)
8180b71 
* Fix strategy functions that update inventory

* added tests


(cherry picked from commit a7b14ec)
abadger pushed a commit that referenced this pull request Aug 2, 2019
@bcoca @abadger
Fix strat inv (#58982)
67fe363 
* Fix strategy functions that update inventory

* added tests


(cherry picked from commit a7b14ec)
@ansible ansible locked and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamescassell jamescassell jamescassell approved these changes

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

force_valid_group_names throws unexpected exception if invalid names used with add_host/group_by
4 participants
@bcoca @jamescassell @s-hertel @ansibot