Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [junos_lag_interfaces] resource module #59011

Merged
merged 4 commits into from
Jul 23, 2019
Merged

Add [junos_lag_interfaces] resource module #59011

merged 4 commits into from
Jul 23, 2019

Conversation

ganeshrn
Copy link
Member

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

junos_lag_interfaces

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 12, 2019

cc @Qalthos @mattclay
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 deprecated This issue/PR relates to a deprecated module. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Jul 12, 2019
@ganeshrn
Add junos_lag_interfaces resource module
6c2fde6 
*  Add new resource module junos_lag_interfaces.
*  Targets model ansible-network/resource_module_models#29
*  Deprecate junos_linkagg module
@ganeshrn ganeshrn added this to Modules in Review in Ansible 2.9 Networking Jul 12, 2019
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 12, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 12, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Jul 12, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@ansible-zuul
Copy link

ansible-zuul bot commented Jul 12, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 12, 2019
@ganeshrn
Copy link
Member Author

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Jul 12, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@ganeshrn
Copy link
Member Author

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Jul 12, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@ikhan2010 ikhan2010 removed this from Modules in Review in Ansible 2.9 Networking Jul 15, 2019
@ikhan2010 ikhan2010 added this to Module in Review in Ansible 2.9 Networking Feature Dev Jul 15, 2019
@ikhan2010 ikhan2010 changed the title Add junos_lag_interfaces resource module Add [junos_lag_interfaces] resource module Jul 15, 2019
@ganeshrn
Copy link
Member Author

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Jul 16, 2019

Build succeeded (third-party-check pipeline).

@ansible-zuul
Copy link

ansible-zuul bot commented Jul 19, 2019

Build succeeded (third-party-check pipeline).

@ganeshrn ganeshrn merged commit 1092ee5 into ansible:devel Jul 23, 2019
@ganeshrn ganeshrn deleted the junos_lag_interfaces branch July 23, 2019 06:23
@trishnaguha trishnaguha moved this from Module in Review to Module Completed in Ansible 2.9 Networking Feature Dev Jul 23, 2019
@ganeshrn ganeshrn mentioned this pull request Jul 29, 2019
Closed
@ansible ansible locked and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha left review comments

@justjais justjais justjais left review comments

@cidrblock cidrblock Awaiting requested review from cidrblock

@NilashishC NilashishC Awaiting requested review from NilashishC

@pabelanger pabelanger Awaiting requested review from pabelanger

@Qalthos Qalthos Awaiting requested review from Qalthos

@rohitthakur2590 rohitthakur2590 Awaiting requested review from rohitthakur2590

@samccann samccann Awaiting requested review from samccann

@danielmellado danielmellado Awaiting requested review from danielmellado

Assignees

@pabelanger pabelanger

@justjais justjais

Labels
affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. deprecated This issue/PR relates to a deprecated module. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
Ansible 2.9 Networking Feature Dev
  
Module Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ganeshrn @ansibot @trishnaguha @justjais @pabelanger