Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear 'connection related' plugin vars for next loop iteration #59024

Merged
merged 3 commits into from Jul 19, 2019
Merged

Clear 'connection related' plugin vars for next loop iteration #59024

merged 3 commits into from Jul 19, 2019

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Jul 12, 2019

SUMMARY

Fixes #58876

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/executor/task_executor.py

@mkrizek mkrizek requested a review from bcoca July 12, 2019 10:03
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 12, 2019
@mkrizek mkrizek changed the title Do not re-use remote_user from previous loop iteration Clear 'connection related' plugin vars for next loop iteration Jul 15, 2019
@mkrizek mkrizek requested a review from bcoca July 15, 2019 10:11
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 16, 2019
jimi-c
jimi-c reviewed Jul 16, 2019
View reviewed changes
Copy link
Member

@jimi-c jimi-c left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, as long as tests are passing.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 18, 2019
@mkrizek mkrizek merged commit a752e2a into ansible:devel Jul 19, 2019
@mkrizek mkrizek deleted the issue-58876 branch July 19, 2019 06:39
mkrizek added a commit to mkrizek/ansible that referenced this pull request Jul 19, 2019
@mkrizek
Clear 'connection related' plugin vars for next loop iteration (ansib…
3c849ab 
…le#59024)

Fixes ansible#58876

(cherry picked from commit a752e2a)
@mkrizek mkrizek mentioned this pull request Jul 19, 2019
Merged
abadger pushed a commit that referenced this pull request Jul 22, 2019
@mkrizek @abadger
Clear 'connection related' plugin vars for next loop iteration (#59024)
5e7e9b5 
Fixes #58876

(cherry picked from commit a752e2a)
abadger added a commit that referenced this pull request Jul 23, 2019
@abadger
Revert "Clear 'connection related' plugin vars for next loop iteration (
a068802 
#59024)"

This reverts commit 5e7e9b5.

This causes a new set of regressions from 2.8.2:
#59284 (comment)

So this issue won't be fixed in 2.8.3 but work towards a fix for 2.8.4
will continue.
This was referenced Jul 23, 2019
Closed
Closed
mkrizek added a commit to mkrizek/ansible that referenced this pull request Jul 24, 2019
@mkrizek
Clear 'connection related' plugin vars for next loop iteration (ansib…
cdc5e8a 
…le#59024)

Fixes ansible#58876

(cherry picked from commit a752e2a)
@mkrizek mkrizek mentioned this pull request Jul 24, 2019
Merged
abadger pushed a commit that referenced this pull request Jul 29, 2019
@mkrizek @abadger
2.8: Clear 'connection related' plugin vars for next loop iteration (#…
ed02720 
…59024) v2 (#59510)

* Clear 'connection related' plugin vars for next loop iteration (#59024)

Fixes #58876

(cherry picked from commit a752e2a)

* Preserve original variables when using a loop (#59426)

Fixes #59414

(cherry picked from commit 1010363)
@ansible ansible locked and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jimi-c jimi-c jimi-c left review comments

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assigning variable to remote_user in loop only works first time
4 participants
@mkrizek @jimi-c @bcoca @ansibot