Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[win_credential] Fix example in docs #59042

Merged
merged 1 commit into from
Jul 12, 2019
Merged

[win_credential] Fix example in docs #59042

merged 1 commit into from
Jul 12, 2019

Conversation

ababushk
Copy link
Contributor

SUMMARY

Just a small update to the latest example.

ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

SUMMARY

I've faced an issue when tried to create a playbook with win_credential task. I've copy-pasted the example and it was slightly wrong - there should be secret parameter instead of password

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

win_credential

@ababushk
[win_credential.py] Fix example in docs
f17eb99 
##### SUMMARY
Just a small update to the latest example. 


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Jul 12, 2019

cc @ShachafGoldstein @if-meaton @jborean93 @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. windows Windows community labels Jul 12, 2019
@acozine
Copy link
Contributor

acozine commented Jul 12, 2019

Thanks @oxygenxo for catching that, and fixing it so other users won't face the problem you ran into!

@acozine acozine removed the needs_triage Needs a first human triage before being processed. label Jul 12, 2019
@acozine
Copy link
Contributor

acozine commented Jul 12, 2019

CI error is unrelated to this change - kicking off a new run.

@acozine acozine merged commit 3b0c933 into ansible:devel Jul 12, 2019
@ansible ansible locked and limited conversation to collaborators Aug 9, 2019
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ababushk @ansibot @acozine @dagwieers