Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_container: add support for nocopy mode #59043

Merged
merged 2 commits into from
Jul 13, 2019
Merged

docker_container: add support for nocopy mode #59043

merged 2 commits into from
Jul 13, 2019

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Jul 12, 2019 •
edited

SUMMARY

Adds support for nocopy volume mount mode to docker_container. That one wasn't added in #46598.

Fixes #58976.

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

docker_container

@ansibot
Copy link
Contributor

ansibot commented Jul 12, 2019

cc @DBendit @WojciechowskiPiotr @akshay196 @chouseknecht @cove @danihodovic @dariko @dusdanig @joshuaconner @jwitko @kassiansun @softzilla @tbouvet @zfil
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 12, 2019
@WojciechowskiPiotr
Copy link
Contributor

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jul 13, 2019
@ansibot ansibot merged commit fa7c387 into ansible:devel Jul 13, 2019
@felixfontein felixfontein deleted the docker_container-nocopy-mode branch July 13, 2019 19:00
@felixfontein
Copy link
Contributor Author

@WojciechowskiPiotr thanks for reviewing!

felixfontein added a commit to felixfontein/ansible that referenced this pull request Jul 13, 2019
@felixfontein
docker_container: add support for nocopy mode (ansible#59043)
6e008cb 
* Add support for nocopy mode.

* Add changelog.

(cherry picked from commit fa7c387)
@felixfontein felixfontein mentioned this pull request Jul 13, 2019
Merged
abadger pushed a commit that referenced this pull request Jul 17, 2019
@felixfontein @abadger
docker_container: add support for nocopy mode (#59043)
1e20cc8 
* Add support for nocopy mode.

* Add changelog.

(cherry picked from commit fa7c387)
@ansible ansible locked and limited conversation to collaborators Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud docker module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docker_container][ansible 2.8] - missing Mount modes on volumes
3 participants
@felixfontein @ansibot @WojciechowskiPiotr