Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature to na_ontap_snapmirror #59047

Merged
merged 2 commits into from
Jul 22, 2019
Merged

New feature to na_ontap_snapmirror #59047

merged 2 commits into from
Jul 22, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

Ability to snapmirror between ONTAP and ElementSW
New options

  • connection_type
  • max_transfer_rate
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • na_ontap_snapmirror.py
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 12, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_snapmirror.py:0:0: E309 version_added for new option (connection_type) should be '2.9'. Currently StrictVersion ('2.8')

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 12, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 ci_verified Changes made in this PR are causing tests to fail. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. netapp storage support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Jul 12, 2019
lonico
lonico approved these changes Jul 14, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

lib/ansible/modules/storage/netapp/na_ontap_snapmirror.py Outdated Show resolved Hide resolved
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 14, 2019
@ansibot ansibot added committer_review In order to be merged, this PR must follow the certified review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 22, 2019
lonico
lonico approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

thedoubl3j
thedoubl3j approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new features documented and tests added. version added fixed. lgtm.

@thedoubl3j thedoubl3j merged commit 6adf0c5 into ansible:devel Jul 22, 2019
@ansible ansible locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonico lonico lonico approved these changes

@thedoubl3j thedoubl3j thedoubl3j approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 committer_review In order to be merged, this PR must follow the certified review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. netapp storage support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carchi8py @ansibot @lonico @thedoubl3j