Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Update main.yml on vmware_dvs_portgroup_facts #59088

Merged
merged 1 commit into from
Jul 17, 2019
Merged

VMware: Update main.yml on vmware_dvs_portgroup_facts #59088

merged 1 commit into from
Jul 17, 2019

Conversation

dx0xm
Copy link
Contributor

@dx0xm dx0xm commented Jul 15, 2019

SUMMARY

New test case to check for a given dvswitch

ISSUE TYPE
  • Feature Pull Request

@ansibot
Copy link
Contributor

ansibot commented Jul 15, 2019

cc @Akasurde @Tomorrow9 @goneri @lparkes @pgbidkar @warthog9
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cloud feature This issue/PR relates to a feature request. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Jul 15, 2019
@dx0xm
Copy link
Contributor Author

dx0xm commented Jul 15, 2019

@Akasurde test is failing correctly as the module does not know yet the new argument, how do we go from here? Is there something I need to do differently?

Please let me know.

"msg": "Unsupported parameters for (vmware_dvs_portgroup_facts) module: dvswitch Supported parameters include: datacenter, hostname, ********word, port, show_network_policy, show_port_policy, show_teaming_policy, username, validate_certs"

@Akasurde
Copy link
Member

@dx0xm There are two options -

  1. Either wait for PR VMware: Gather facts about vlan id from DVS Portgroup in vmware_dvs_portgroup_facts #59085 to get merge
  2. or add test case from this PR in PR VMware: Gather facts about vlan id from DVS Portgroup in vmware_dvs_portgroup_facts #59085 directly.

Thanks

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 15, 2019
@dx0xm
Copy link
Contributor Author

dx0xm commented Jul 15, 2019

@Akasurde Thanks.

Will try the first option for now as I tried the second one yesterday and the pull went crazy.

@Akasurde Akasurde self-assigned this Jul 17, 2019
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Jul 17, 2019
@ansibot ansibot added the module This issue/PR relates to a module. label Jul 17, 2019
@dx0xm @Akasurde
VMware: Add testcase for vmware_dvs_portgroup_facts
276d71b 
* Tests for choosing specific DVS while gathering facts

Signed-off-by: dx0xm <52723266+dx0xm@users.noreply.github.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 17, 2019
@Akasurde Akasurde merged commit b8eba8e into ansible:devel Jul 17, 2019
@dx0xm dx0xm deleted the patch-1 branch July 18, 2019 04:33
@ansible ansible locked and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Akasurde Akasurde

Labels
affects_2.9 This issue/PR affects Ansible v2.9 cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dx0xm @ansibot @Akasurde