VMware: Use managed object id to find VM #59143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wilmardo Thanks for the contribution. I have used your code in this PR. Could you please review this ? Thanks in advance. |
|
Yes! Thanks for picking this up, did not have the time to look into the failing test and mocking the module. Looks good to me! Also thanks to @jeking3 for the initial review :) |
ansibot
added
affects_2.9
ansibot
added
needs_revision
Akasurde
force-pushed
the
vmware_guest_moid
branch
from
6b6c917
to
0e64f61
Compare
ansibot
added
community_review
Akasurde
removed
the
needs_triage
|
We can also add a couple of examples (name and uuid are presented there) |
* Based upon partial work of wilmardo * Now, user can specify managed object id of virtual machine to find an existing virtual machine Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Akasurde
force-pushed
the
vmware_guest_moid
branch
from
0e64f61
to
952db74
Compare
jillr
approved these changes
Jul 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
an existing virtual machine
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
lib/ansible/module_utils/vmware.py
lib/ansible/modules/cloud/vmware/vmware_export_ovf.py
lib/ansible/modules/cloud/vmware/vmware_guest_boot_facts.py
lib/ansible/modules/cloud/vmware/vmware_guest_boot_manager.py
lib/ansible/modules/cloud/vmware/vmware_guest_custom_attributes.py
lib/ansible/modules/cloud/vmware/vmware_guest_disk.py
lib/ansible/modules/cloud/vmware/vmware_guest_disk_facts.py
lib/ansible/modules/cloud/vmware/vmware_guest_facts.py
lib/ansible/modules/cloud/vmware/vmware_guest_move.py
lib/ansible/modules/cloud/vmware/vmware_guest_network.py
lib/ansible/modules/cloud/vmware/vmware_guest_powerstate.py
lib/ansible/modules/cloud/vmware/vmware_guest_screenshot.py
lib/ansible/modules/cloud/vmware/vmware_guest_sendkey.py
lib/ansible/modules/cloud/vmware/vmware_guest_snapshot.py
lib/ansible/modules/cloud/vmware/vmware_guest_snapshot_facts.py
lib/ansible/modules/cloud/vmware/vmware_guest_tools_upgrade.py
lib/ansible/modules/cloud/vmware/vmware_guest_tools_wait.py
lib/ansible/modules/cloud/vmware/vmware_guest_video.py
lib/ansible/modules/cloud/vmware/vmware_guest_vnc.py
lib/ansible/modules/cloud/vmware/vmware_vmotion.py
test/integration/targets/vmware_guest_facts/tasks/main.yml