Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for GCP (as of 2019-07-09T06:06:53Z) #59172

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Bug fixes for GCP (as of 2019-07-09T06:06:53Z) #59172

merged 2 commits into from
Jul 19, 2019

Conversation

modular-magician
Copy link
Contributor

SUMMARY

Bug fixes for GCP (as of 2019-07-09T06:06:53Z)
This PR is the result of the following Magic Modules PRs:

ISSUE TYPE
  • Bugfix Pull Request
ADDITIONAL INFORMATION
This was generated by [Magic Modules](https://github.com/googlecloudplatform/magic-modules)

@ansibot
Copy link
Contributor

ansibot commented Jul 17, 2019

cc @erjohnso @GoogleCloudPlatform @rambleraptor
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 17, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 17, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

test/sanity/validate-modules/ignore.txt:720:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_container_cluster_facts.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:722:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_container_node_pool_facts.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:726:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_dns_resource_record_set_facts.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:742:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_redis_instance_facts.py" passes "E337" test

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 17, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 18, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 18, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

test/sanity/validate-modules/ignore.txt:720:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_container_cluster_facts.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:722:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_container_node_pool_facts.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:726:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_dns_resource_record_set_facts.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:742:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_redis_instance_facts.py" passes "E337" test

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 18, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. and removed ci_verified Changes made in this PR are causing tests to fail. labels Jul 18, 2019
@rambleraptor
Copy link
Contributor

shipit

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Jul 18, 2019
@rambleraptor
Copy link
Contributor

@gundalow, @mattclay or others: could somebody merge this? The Google stuff looks great, but I don't have permission to ship changes to test/sanity/validate-modules/ignore.txt

@mattclay mattclay merged commit c5e26ab into ansible:devel Jul 19, 2019
@ansible ansible locked and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. gce module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@modular-magician @ansibot @rambleraptor @mattclay