Initial ansible-test support for collections. #59197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
mattclay
removed
the
needs_triage
ansibot
added
needs_revision
ansibot
removed
the
needs_revision
ci_complete ci_coverage
mattclay
force-pushed
the
at-collections-preview
branch
from
e187780
to
93ef4dd
Compare
|
Full coverage run: https://app.shippable.com/github/ansible/ansible/runs/132593/ The timeouts are unrelated to the changes. |
ansibot
removed
the
core_review
pabelanger
added a commit
to pabelanger/ansible
that referenced
this pull request
Jul 18, 2019
Depends-On: ansible#59197 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
jborean93
reviewed
Jul 19, 2019
The module option can be plural but powershell must be singular.
This makes it more obvious what the variables are referencing and keeps them consistent. - `is_install` -> `is_ansible` - `INSTALL_ROOT` -> `ANSIBLE_ROOT`
jborean93
reviewed
Jul 22, 2019
jborean93
approved these changes
Jul 22, 2019
mattclay
removed
needs_revision
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Initial ansible-test support for collections.
This maintains existing support for using ansible-test on the Ansible source while providing the initial refactoring needed to support testing of Ansible collections.
Collections testing support is still an early preview. Many features for testing collections are incomplete, have bugs or are completely missing. Some existing features will change significantly in subsequent PRs.
The primary change in existing behavior is that ansible-test can no longer be invoked from a current working directory outside of the content root being tested.
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
ansible-test