point at corresponding version

[bcoca]

modules were always pointing at latest

fixes #54736

ISSUE TYPE

• Bugfix Pull Request
• Docs Pull Request

COMPONENT NAME

ansible-doc

[acozine]

CI failures seem unrelated to the changes. Kicking off a new run.

[acozine]

I published this branch to the test site and went to compare the old/bad/wrong behavior in prod against the new/good/correct behavior introduced by this PR . . . and now I can't replicate the bug. In the module docs, the seealso links point to the same version as the originating page. It's odd, I don't quite know what to think, but I'm going to leave this PR open until Monday.

[bcoca]

@acozine you would have to use stable branches to reproduce the issue:
using 'stable-2.8' I run ansible-doc copy and I get:

SEE ALSO:
      * Module assemble
           The official documentation on the assemble module.
           https://docs.ansible.com/ansible/latest/modules/assemble_module.html

which is 'correct' for now, but once 2.9 is released .. it won't be

with PR i get

SEE ALSO:
      * Module assemble
           The official documentation on the assemble module.
           https://docs.ansible.com/ansible/2.8/modules/assemble_module.html

which should 'always' be true

[acozine]

I thought this behavior happened in the published docs as well, and happened in devel - i.e. I thought links in the See Also section in the devel docs were pointing at latest. But I can't recreate that behavior now.

+1 to merging this fix. When 2.9 comes out we can test the behavior in the published docs again.

[akatch]

I'm curious as to why the condtional on description existing for the item was removed in this change. Can you elaborate?

[bcoca]

@akatch that was existing, i just refactored the 'common parts' out of it, so took 11 lines down to 3

[akatch]

Got it. shipit