Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win setup fix 2.8 #59211

Merged
merged 2 commits into from Jul 22, 2019
Merged

Win setup fix 2.8 #59211

merged 2 commits into from Jul 22, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

Backport of #58483

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

setup

Michael Letterle and others added 2 commits July 18, 2019 11:43
@jborean93
Wrap Get-MachineSid's body in a try/catch
b274bf7 
It's not critical information and there's been a number of issues over
the years with trying to retrieve it. If an exception is thrown just
return null.

Fixes: ansible#47813
(cherry picked from commit b8a41a9)
@nitzmahone @jborean93
add changelog
15e9cda 
(cherry picked from commit 277690b)
@jborean93 jborean93 mentioned this pull request Jul 18, 2019
Merged
@ansibot
Copy link
Contributor

ansibot commented Jul 18, 2019

cc @ShachafGoldstein @if-meaton @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Jul 18, 2019
@nitzmahone
Copy link
Member

Thanks for creating the backport @jborean93 - I hit the merge conflict then got pulled into something else before I'd resolved it.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 18, 2019
@abadger abadger merged commit a2d6f9a into ansible:stable-2.8 Jul 22, 2019
@abadger
Copy link
Contributor

abadger commented Jul 22, 2019

Merged for the 2.8.3 release

@jborean93 jborean93 deleted the win-setup-fix-2.8 branch July 22, 2019 22:24
@ansible ansible locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jborean93 @ansibot @nitzmahone @abadger