Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Add datatypes in documentation #59221

Merged
merged 1 commit into from
Jul 24, 2019
Merged

VMware: Add datatypes in documentation #59221

merged 1 commit into from
Jul 24, 2019

Conversation

Akasurde
Copy link
Member

SUMMARY
  • Remove E337 warnings
  • Update docs
  • Fix minor typos

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vcenter_extension.py
lib/ansible/modules/cloud/vmware/vcenter_folder.py
lib/ansible/modules/cloud/vmware/vcenter_license.py
lib/ansible/modules/cloud/vmware/vmware_category.py
lib/ansible/modules/cloud/vmware/vmware_cfg_backup.py
lib/ansible/modules/cloud/vmware/vmware_cluster_facts.py
lib/ansible/modules/cloud/vmware/vmware_datacenter.py
lib/ansible/modules/cloud/vmware/vmware_datastore_cluster.py
lib/ansible/modules/cloud/vmware/vmware_datastore_facts.py
lib/ansible/modules/cloud/vmware/vmware_datastore_maintenancemode.py
lib/ansible/modules/cloud/vmware/vmware_dns_config.py
lib/ansible/modules/cloud/vmware/vmware_drs_group.py
lib/ansible/modules/cloud/vmware/vmware_drs_group_facts.py
lib/ansible/modules/cloud/vmware/vmware_drs_rule_facts.py
lib/ansible/modules/cloud/vmware/vmware_dvs_host.py
lib/ansible/modules/cloud/vmware/vmware_dvs_portgroup.py
lib/ansible/modules/cloud/vmware/vmware_dvswitch.py
lib/ansible/modules/cloud/vmware/vmware_dvswitch_lacp.py
lib/ansible/modules/cloud/vmware/vmware_dvswitch_pvlans.py
lib/ansible/modules/cloud/vmware/vmware_dvswitch_uplink_pg.py
lib/ansible/modules/cloud/vmware/vmware_export_ovf.py
lib/ansible/modules/cloud/vmware/vmware_guest_boot_facts.py
lib/ansible/modules/cloud/vmware/vmware_guest_boot_manager.py
lib/ansible/modules/cloud/vmware/vmware_guest_custom_attribute_defs.py
lib/ansible/modules/cloud/vmware/vmware_guest_custom_attributes.py
lib/ansible/modules/cloud/vmware/vmware_guest_customization_facts.py
lib/ansible/modules/cloud/vmware/vmware_guest_disk.py
lib/ansible/modules/cloud/vmware/vmware_guest_disk_facts.py
lib/ansible/modules/cloud/vmware/vmware_guest_facts.py
lib/ansible/modules/cloud/vmware/vmware_guest_file_operation.py
lib/ansible/modules/cloud/vmware/vmware_guest_find.py
lib/ansible/modules/cloud/vmware/vmware_guest_move.py
lib/ansible/modules/cloud/vmware/vmware_guest_powerstate.py
lib/ansible/modules/cloud/vmware/vmware_guest_snapshot.py
lib/ansible/modules/cloud/vmware/vmware_guest_snapshot_facts.py
lib/ansible/modules/cloud/vmware/vmware_guest_tools_upgrade.py
lib/ansible/modules/cloud/vmware/vmware_guest_tools_wait.py
lib/ansible/modules/cloud/vmware/vmware_guest_video.py
lib/ansible/modules/cloud/vmware/vmware_guest_vnc.py
lib/ansible/modules/cloud/vmware/vmware_host_acceptance.py
lib/ansible/modules/cloud/vmware/vmware_host_capability_facts.py
lib/ansible/modules/cloud/vmware/vmware_host_config_facts.py
lib/ansible/modules/cloud/vmware/vmware_host_config_manager.py
lib/ansible/modules/cloud/vmware/vmware_host_datastore.py
lib/ansible/modules/cloud/vmware/vmware_host_dns_facts.py
lib/ansible/modules/cloud/vmware/vmware_host_facts.py
lib/ansible/modules/cloud/vmware/vmware_host_feature_facts.py
lib/ansible/modules/cloud/vmware/vmware_host_firewall_facts.py
lib/ansible/modules/cloud/vmware/vmware_host_firewall_manager.py
lib/ansible/modules/cloud/vmware/vmware_host_lockdown.py
lib/ansible/modules/cloud/vmware/vmware_host_ntp_facts.py
lib/ansible/modules/cloud/vmware/vmware_host_package_facts.py
lib/ansible/modules/cloud/vmware/vmware_host_powermgmt_policy.py
lib/ansible/modules/cloud/vmware/vmware_host_powerstate.py
lib/ansible/modules/cloud/vmware/vmware_host_scanhba.py
lib/ansible/modules/cloud/vmware/vmware_host_service_facts.py
lib/ansible/modules/cloud/vmware/vmware_host_service_manager.py
lib/ansible/modules/cloud/vmware/vmware_host_snmp.py
lib/ansible/modules/cloud/vmware/vmware_host_ssl_facts.py
lib/ansible/modules/cloud/vmware/vmware_host_vmnic_facts.py
lib/ansible/modules/cloud/vmware/vmware_local_role_manager.py
lib/ansible/modules/cloud/vmware/vmware_local_user_manager.py
lib/ansible/modules/cloud/vmware/vmware_maintenancemode.py
lib/ansible/modules/cloud/vmware/vmware_migrate_vmk.py
lib/ansible/modules/cloud/vmware/vmware_object_role_permission.py
lib/ansible/modules/cloud/vmware/vmware_portgroup.py
lib/ansible/modules/cloud/vmware/vmware_portgroup_facts.py
lib/ansible/modules/cloud/vmware/vmware_resource_pool.py
lib/ansible/modules/cloud/vmware/vmware_tag.py
lib/ansible/modules/cloud/vmware/vmware_tag_manager.py
lib/ansible/modules/cloud/vmware/vmware_target_canonical_facts.py
lib/ansible/modules/cloud/vmware/vmware_vm_host_drs_rule.py
lib/ansible/modules/cloud/vmware/vmware_vm_shell.py
lib/ansible/modules/cloud/vmware/vmware_vm_vm_drs_rule.py
lib/ansible/modules/cloud/vmware/vmware_vm_vss_dvs_migrate.py
lib/ansible/modules/cloud/vmware/vmware_vmkernel.py
lib/ansible/modules/cloud/vmware/vmware_vmkernel_facts.py
lib/ansible/modules/cloud/vmware/vmware_vmkernel_ip_config.py
lib/ansible/modules/cloud/vmware/vmware_vmotion.py
lib/ansible/modules/cloud/vmware/vmware_vsan_cluster.py
lib/ansible/modules/cloud/vmware/vmware_vspan_session.py
lib/ansible/modules/cloud/vmware/vmware_host_snmp.py
lib/ansible/modules/cloud/vmware/vmware_host_ssl_facts.py
lib/ansible/modules/cloud/vmware/vmware_host_vmnic_facts.py
lib/ansible/modules/cloud/vmware/vmware_local_role_manager.py
lib/ansible/modules/cloud/vmware/vmware_local_user_manager.py
lib/ansible/modules/cloud/vmware/vmware_maintenancemode.py
lib/ansible/modules/cloud/vmware/vmware_migrate_vmk.py
lib/ansible/modules/cloud/vmware/vmware_object_role_permission.py
lib/ansible/modules/cloud/vmware/vmware_portgroup.py
lib/ansible/modules/cloud/vmware/vmware_portgroup_facts.py
lib/ansible/modules/cloud/vmware/vmware_resource_pool.py
lib/ansible/modules/cloud/vmware/vmware_tag.py
lib/ansible/modules/cloud/vmware/vmware_tag_manager.py
lib/ansible/modules/cloud/vmware/vmware_target_canonical_facts.py
lib/ansible/modules/cloud/vmware/vmware_vm_host_drs_rule.py
lib/ansible/modules/cloud/vmware/vmware_vm_shell.py
lib/ansible/modules/cloud/vmware/vmware_vm_vm_drs_rule.py
lib/ansible/modules/cloud/vmware/vmware_vm_vss_dvs_migrate.py
lib/ansible/modules/cloud/vmware/vmware_vmkernel.py
lib/ansible/modules/cloud/vmware/vmware_vmkernel_facts.py
lib/ansible/modules/cloud/vmware/vmware_vmkernel_ip_config.py
lib/ansible/modules/cloud/vmware/vmware_vmotion.py
lib/ansible/modules/cloud/vmware/vmware_vsan_cluster.py
lib/ansible/modules/cloud/vmware/vmware_vspan_session.py
lib/ansible/modules/cloud/vmware/vmware_vswitch.py
lib/ansible/modules/cloud/vmware/vmware_vswitch_facts.py
test/sanity/validate-modules/ignore.txt

@ansibot
Copy link
Contributor

ansibot commented Jul 18, 2019

@Akasurde This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Jul 18, 2019
@Akasurde
VMware: Add datatypes in documentation
97efb9b 
* Remove E337 warnings
* Update docs
* Fix minor typos

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde requested review from goneri and jillr July 23, 2019 02:06
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 23, 2019
@Akasurde Akasurde merged commit d9b9e07 into ansible:devel Jul 24, 2019
@Akasurde Akasurde deleted the vmware_type branch July 24, 2019 02:25
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 24, 2019
@ansible ansible locked and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jillr jillr jillr approved these changes

@goneri goneri Awaiting requested review from goneri

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Akasurde @ansibot @jillr @sivel