Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render elements in module doc and sanity test for sub-options #59244

Merged
merged 7 commits into from
Jul 30, 2019
Merged

Render elements in module doc and sanity test for sub-options #59244

merged 7 commits into from
Jul 30, 2019

Conversation

ganeshrn
Copy link
Member

@ganeshrn ganeshrn commented Jul 18, 2019 •
edited

SUMMARY
  • Add support to render module elements value in ansible-doc output and
    module HTML doc
  • Add validate-module sanity test for suboptions.
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

docs/docsite/rst/dev_guide/testing_validate-modules.rst
docs/templates/plugin.rst.j2
test/sanity/validate-modules/main.py
test/sanity/validate-modules/schema.py

ADDITIONAL INFORMATION

The element's value in doc is displayed as
elements_out

@ansibot
Copy link
Contributor

ansibot commented Jul 18, 2019

cc @acozine @gundalow @mattclay @sivel
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 18, 2019
@ganeshrn ganeshrn force-pushed the elements_fix branch 2 times, most recently from a64990a to 790a405 Compare July 18, 2019 15:00
@ganeshrn
Copy link
Member Author

The validate module sanity failures in shippable are valid failures since this PR now validates recursively over sub-options. Will add it to the ignore list modules for now

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 18, 2019
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 19, 2019
@ansible ansible deleted a comment from ansibot Jul 19, 2019
@ikhan2010 ikhan2010 added this to Needs Triage in Networking via automation Jul 22, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 24, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 59 errors:

lib/ansible/modules/cloud/vmware/vmware_dvs_host.py:0:0: E322 Argument 'key' found in vendor_specific_config is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/vmware/vmware_dvs_host.py:0:0: E322 Argument 'value' found in vendor_specific_config is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/vmware/vmware_dvs_host.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_dvs_host.py:0:0: E340 Argument 'vendor_specific_config' in argument_spec has sub-options but documentation does not define it
lib/ansible/modules/cloud/vmware/vmware_dvs_portgroup.py:0:0: E337  defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_dvs_portgroup.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_dvswitch_uplink_pg.py:0:0: E337  defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_dvswitch_uplink_pg.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_guest_custom_attributes.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_guest_file_operation.py:0:0: E337  defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_guest_file_operation.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_portgroup.py:0:0: E337  defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_portgroup.py:0:0: E337  defines type as 'int' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_portgroup.py:0:0: E337  defines type as 'list' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_portgroup.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_vmkernel.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_vspan_session.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'active' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'description' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'device_count' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'members' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'min_links' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'mode' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'name' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'state' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'transport' found in provider is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E326 Argument 'mode' in argument_spec found in aggregate defines choices as (['on', 'off', 'active', 'passive']) but documentation defines choices as ([])
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E326 Argument 'state' in argument_spec found in aggregate defines choices as (['present', 'absent', 'up', 'down']) but documentation defines choices as ([])
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E326 Argument 'transport' in argument_spec found in provider defines choices as (['cli', 'netconf']) but documentation defines choices as ([])
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E340 Argument 'aggregate' in argument_spec has sub-options but documentation does not define it
lib/ansible/modules/network/junos/junos_lag_interfaces.py:0:0: E338 Argument 'link_type' in argument_spec found in config -> members uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/junos/junos_lag_interfaces.py:0:0: E338 Argument 'mode' in argument_spec found in config uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E322 Argument 'force' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E322 Argument 'group' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E322 Argument 'members' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E322 Argument 'min_links' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E322 Argument 'mode' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E322 Argument 'state' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E324 Argument 'timeout' in argument_spec found in provider defines default as (None) but documentation defines default as (10)
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E324 Argument 'validate_certs' in argument_spec found in provider defines default as (False) but documentation defines default as (True)
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E326 Argument 'mode' in argument_spec found in aggregate defines choices as (['on', 'active', 'passive']) but documentation defines choices as ([])
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E326 Argument 'state' in argument_spec found in aggregate defines choices as (['absent', 'present']) but documentation defines choices as ([])
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E327 Argument 'port' in documentation found in provider defines default as ('0 (use common port)') but this is incompatible with parameter type 'int'
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E337  defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E337  defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E337  defines type as 'list' but documentation doesn't define type
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E338 Argument 'group' in argument_spec found in aggregate uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E338 Argument 'state' in argument_spec found in aggregate uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E340 Argument 'aggregate' in argument_spec has sub-options but documentation does not define it
lib/ansible/modules/network/nxos/nxos_lag_interfaces.py:0:0: E326 Argument 'mode' in argument_spec found in config -> members defines choices as (['active', 'on', 'passive']) but documentation defines choices as (['active', 'True', 'passive'])
test/sanity/validate-modules/ignore.txt:3638:1: A100 File 'lib/ansible/modules/network/junos/junos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3639:1: A100 File 'lib/ansible/modules/network/junos/junos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3640:1: A100 File 'lib/ansible/modules/network/junos/junos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3914:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3915:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3916:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3917:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3918:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 24, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 59 errors:

lib/ansible/modules/cloud/vmware/vmware_dvs_host.py:0:0: E322 Argument 'key' found in vendor_specific_config is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/vmware/vmware_dvs_host.py:0:0: E322 Argument 'value' found in vendor_specific_config is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/vmware/vmware_dvs_host.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_dvs_host.py:0:0: E340 Argument 'vendor_specific_config' in argument_spec has sub-options but documentation does not define it
lib/ansible/modules/cloud/vmware/vmware_dvs_portgroup.py:0:0: E337  defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_dvs_portgroup.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_dvswitch_uplink_pg.py:0:0: E337  defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_dvswitch_uplink_pg.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_guest_custom_attributes.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_guest_file_operation.py:0:0: E337  defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_guest_file_operation.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_portgroup.py:0:0: E337  defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_portgroup.py:0:0: E337  defines type as 'int' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_portgroup.py:0:0: E337  defines type as 'list' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_portgroup.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_vmkernel.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_vspan_session.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'active' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'description' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'device_count' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'members' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'min_links' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'mode' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'name' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'state' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E322 Argument 'transport' found in provider is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E326 Argument 'mode' in argument_spec found in aggregate defines choices as (['on', 'off', 'active', 'passive']) but documentation defines choices as ([])
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E326 Argument 'state' in argument_spec found in aggregate defines choices as (['present', 'absent', 'up', 'down']) but documentation defines choices as ([])
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E326 Argument 'transport' in argument_spec found in provider defines choices as (['cli', 'netconf']) but documentation defines choices as ([])
lib/ansible/modules/network/junos/_junos_linkagg.py:0:0: E340 Argument 'aggregate' in argument_spec has sub-options but documentation does not define it
lib/ansible/modules/network/junos/junos_lag_interfaces.py:0:0: E338 Argument 'link_type' in argument_spec found in config -> members uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/junos/junos_lag_interfaces.py:0:0: E338 Argument 'mode' in argument_spec found in config uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E322 Argument 'force' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E322 Argument 'group' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E322 Argument 'members' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E322 Argument 'min_links' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E322 Argument 'mode' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E322 Argument 'state' found in aggregate is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E324 Argument 'timeout' in argument_spec found in provider defines default as (None) but documentation defines default as (10)
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E324 Argument 'validate_certs' in argument_spec found in provider defines default as (False) but documentation defines default as (True)
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E326 Argument 'mode' in argument_spec found in aggregate defines choices as (['on', 'active', 'passive']) but documentation defines choices as ([])
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E326 Argument 'state' in argument_spec found in aggregate defines choices as (['absent', 'present']) but documentation defines choices as ([])
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E327 Argument 'port' in documentation found in provider defines default as ('0 (use common port)') but this is incompatible with parameter type 'int'
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E337  defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E337  defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E337  defines type as 'list' but documentation doesn't define type
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E337  defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E338 Argument 'group' in argument_spec found in aggregate uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E338 Argument 'state' in argument_spec found in aggregate uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/nxos/_nxos_linkagg.py:0:0: E340 Argument 'aggregate' in argument_spec has sub-options but documentation does not define it
lib/ansible/modules/network/nxos/nxos_lag_interfaces.py:0:0: E326 Argument 'mode' in argument_spec found in config -> members defines choices as (['active', 'on', 'passive']) but documentation defines choices as (['active', 'True', 'passive'])
test/sanity/validate-modules/ignore.txt:3638:1: A100 File 'lib/ansible/modules/network/junos/junos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3639:1: A100 File 'lib/ansible/modules/network/junos/junos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3640:1: A100 File 'lib/ansible/modules/network/junos/junos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3914:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3915:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3916:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3917:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3918:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 25, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 9 errors:

lib/ansible/modules/network/nxos/nxos_lag_interfaces.py:0:0: E326 Argument 'mode' in argument_spec found in config -> members defines choices as (['active', 'on', 'passive']) but documentation defines choices as (['active', 'True', 'passive'])
test/sanity/validate-modules/ignore.txt:3652:1: A100 File 'lib/ansible/modules/network/junos/junos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3653:1: A100 File 'lib/ansible/modules/network/junos/junos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3654:1: A100 File 'lib/ansible/modules/network/junos/junos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3935:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3936:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3937:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3938:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist
test/sanity/validate-modules/ignore.txt:3939:1: A100 File 'lib/ansible/modules/network/nxos/nxos_linkagg.py' does not exist

click here for bot help

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 25, 2019
@webknjaz
Copy link
Member

Hey @ganeshrn, this PR is out of sync with devel. Could you please fix this?

@webknjaz
Copy link
Member

Could you please move out the ignore entries reordering into a separate PR?

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 29, 2019
@samccann
Copy link
Contributor

@ganeshrn can you point me to some modules in your branch that will exercise this new docs code so I can take a look?

@ganeshrn
Render elements in module doc and sanity test for suboptions
c26934a 
*  Add support to render module elements value in ansible-doc output
   module html
*  Add validate-module sanity test of sunoptions.
@ganeshrn
Add current validate module failures to ignore list
617c770
@ganeshrn
Fix CI failure
73330e3
@ganeshrn
fix rebase conflict
fe8d069
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jul 30, 2019
@ganeshrn
Copy link
Member Author

@webknjaz Ignore list file is moved out of validate-modules folder as part of #59618

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 30, 2019
@ganeshrn
Copy link
Member Author

ganeshrn commented Jul 30, 2019 •
edited

@webknjaz I have fixed your review comments.

@webknjaz @samccann
Since this PR has a considerable amount of changes in ignore-changes.txt I had to rebase it multiple times due to merge conflicts.
Since the CI is passing now, I will go ahead and merge this PR which will unblock merge for a number of other network resource module PR's.

If there are any more review comments/issues I will fix it in a separate PR.

@ganeshrn ganeshrn merged commit 127bd67 into ansible:devel Jul 30, 2019
Networking automation moved this from Needs Triage to Done Jul 30, 2019
@ganeshrn ganeshrn deleted the elements_fix branch July 30, 2019 06:37
@ganeshrn ganeshrn mentioned this pull request Aug 8, 2019
Merged
@acozine acozine mentioned this pull request Aug 8, 2019
Closed
@ansible ansible locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webknjaz webknjaz webknjaz left review comments

@NilashishC NilashishC NilashishC approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. feature This issue/PR relates to a feature request. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
Networking
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ganeshrn @ansibot @webknjaz @samccann @NilashishC @bcoca