prevent templating of passwords from prompt #59246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
bcoca
removed
the
needs_triage
ansibot
added
shipit
sivel
requested changes
Jul 24, 2019
ansibot
added
needs_revision
sivel
approved these changes
Jul 24, 2019
|
agreed, but since this is for backport i want to keep as simple as possible to avoid other side effects |
ansibot
added
core_review
bcoca
added a commit
to bcoca/ansible
that referenced
this pull request
Jul 24, 2019
* prevent templating of passwords from prompt fixes CVE-2019-10206 (cherry picked from commit e9a37f8)
bcoca
added a commit
to bcoca/ansible
that referenced
this pull request
Jul 24, 2019
* prevent templating of passwords from prompt fixes CVE-2019-10206 (cherry picked from commit e9a37f8)
bcoca
added a commit
to bcoca/ansible
that referenced
this pull request
Jul 24, 2019
* prevent templating of passwords from prompt fixes CVE-2019-10206 (cherry picked from commit e9a37f8)
abadger
pushed a commit
that referenced
this pull request
Aug 7, 2019
* prevent templating of passwords from prompt fixes CVE-2019-10206 (cherry picked from commit e9a37f8)
abadger
pushed a commit
that referenced
this pull request
Aug 13, 2019
* prevent templating of passwords from prompt (#59246) * prevent templating of passwords from prompt fixes CVE-2019-10206 (cherry picked from commit e9a37f8) * Improve performane of UnsafeProxy __new__ This adds an early return to the __new__ method of the UnsafeProxy object which avoids creating the unsafe object if the incoming object is already unsafe. (cherry picked from commit c1e23c2) (cherry picked from commit 490f17c)
abadger
pushed a commit
that referenced
this pull request
Aug 13, 2019
* prevent templating of passwords from prompt (#59246) * prevent templating of passwords from prompt fixes CVE-2019-10206 (cherry picked from commit e9a37f8) * Improve performane of UnsafeProxy __new__ This adds an early return to the __new__ method of the UnsafeProxy object which avoids creating the unsafe object if the incoming object is already unsafe. (cherry picked from commit c1e23c2) (cherry picked from commit 490f17c)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So
hello{{worldis now a valid password at the promptfixes CVE-2019-10206
ISSUE TYPE
COMPONENT NAME
core