Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change sub_plugin check to completely ignore napalm #59298

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Change sub_plugin check to completely ignore napalm #59298

merged 1 commit into from
Jul 31, 2019

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Jul 19, 2019

This also fixes cases where sub_plugin might not be loaded in executor

SUMMARY

Hopefully unmasks the real problem in #58985.
type: external isn't any more useful than not having it at all, and adds weirdness that I'd rather avoid.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

task_executor

@Qalthos
Change sub_plugin check to completely ignore napalm
a3ccede 
This also fixes cases where sub_plugin might not be loaded in executor
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 19, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 23, 2019
@pabelanger pabelanger mentioned this pull request Jul 24, 2019
Closed
@Qalthos Qalthos merged commit 80d8058 into ansible:devel Jul 31, 2019
@Qalthos Qalthos deleted the network_connection_type branch July 31, 2019 12:46
@ansible ansible locked and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Qalthos @bcoca @ansibot