Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ce_mlag_config: update to fix a bug. #59336

Merged
merged 4 commits into from
Jul 25, 2019
Merged

ce_mlag_config: update to fix a bug. #59336

merged 4 commits into from
Jul 25, 2019

Conversation

yuandongx
Copy link
Contributor

@yuandongx yuandongx commented Jul 20, 2019

SUMMARY

ce_mlag_config: update to fix a bug.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/network/cloudengine/ce_mlag_config.py

ADDITIONAL INFORMATION

The test task

  - name: "Step4.1.1 test the correct pseudo_priority"
    ce_mlag_config:
      dfs_group_id: 1
      pseudo_priority: 128
      pseudo_nickname: 10
      state: absent

Before Modify, the error log.

changed: [10.190.121.125] => {
    "ansible_facts": {
        "discovered_interpreter_python": "/usr/bin/python"
    },
    "changed": true,
    "end_state": {
        "dfs_group_id": "1",
        "pseudo_nickname": "10",
        "pseudo_priority": "128"
    },
    "existing": {
        "dfs_group_id": "1",
        "pseudo_nickname": "10",
        "pseudo_priority": "128"
    },
    "invocation": {
        "module_args": {
            "dfs_group_id": "1",
            "eth_trunk_id": null,
            "host": "10.190.121.125",
            "ip_address": null,
            "nickname": null,
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "peer_link_id": null,
            "port": 10111,
            "priority_id": null,
            "provider": {
                "host": "10.190.121.125",
                "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
                "port": 10111,
                "ssh_keyfile": null,
                "timeout": null,
                "transport": "cli",
                "use_ssl": null,
                "username": "huawei",
                "validate_certs": null
            },
            "pseudo_nickname": "10",
            "pseudo_priority": "128",
            "ssh_keyfile": null,
            "state": "absent",
            "timeout": null,
            "transport": "cli",
            "use_ssl": null,
            "username": "huawei",
            "validate_certs": null,
            "vpn_instance_name": null
        }
    },
    "proposed": {
        "dfs_group_id": "1",
        "pseudo_nickname": "10",
        "pseudo_priority": "128",
        "state": "absent"
    },
    "updates": [
        "dfs-group 1",
        "undo pseudo-nickname 10 priority 128"
    ]
}

Dubug Result

Configuration does not absent as expect.
Because of running commands via netconf API.

After Modify.

Test log.

changed: [10.190.121.125] => {
    "ansible_facts": {
        "discovered_interpreter_python": "/usr/bin/python"
    },
    "changed": true,
    "end_state": {
        "dfs_group_id": "1",
        "pseudo_nickname": "11",
        "pseudo_priority": "192"
    },
    "existing": {
        "dfs_group_id": "1",
        "pseudo_nickname": "11",
        "pseudo_priority": "255"
    },
    "invocation": {
        "module_args": {
            "dfs_group_id": "1",
            "eth_trunk_id": null,
            "host": "10.190.121.125",
            "ip_address": null,
            "nickname": null,
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "peer_link_id": null,
            "port": 10111,
            "priority_id": null,
            "provider": {
                "host": "10.190.121.125",
                "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
                "port": 10111,
                "ssh_keyfile": null,
                "timeout": null,
                "transport": "cli",
                "use_ssl": null,
                "username": "huawei",
                "validate_certs": null
            },
            "pseudo_nickname": "11",
            "pseudo_priority": "255",
            "ssh_keyfile": null,
            "state": "absent",
            "timeout": null,
            "transport": "cli",
            "use_ssl": null,
            "username": "huawei",
            "validate_certs": null,
            "vpn_instance_name": null
        }
    },
    "proposed": {
        "dfs_group_id": "1",
        "pseudo_nickname": "11",
        "pseudo_priority": "255",
        "state": "absent"
    },
    "updates": [
        "dfs-group 1",
        "undo priority 255"
    ]
}
META: ran handlers
META: ran handlers

PLAY RECAP **************************************************************************************
10.190.121.125             : ok=1    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

show configure on device

[~8850_130.12-dfs-group-1]di th
#
dfs-group 1
 pseudo-nickname 11 priority 255
 source nickname 1
#
return
[~8850_130.12-dfs-group-1]di th
#
dfs-group 1
 source nickname 1
 pseudo-nickname 11
#
return
[~8850_130.12-dfs-group-1]di th

@ansibot
Copy link
Contributor

ansibot commented Jul 20, 2019

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 20, 2019
@yuandongx yuandongx marked this pull request as ready for review July 20, 2019 12:05
@yuandongxx
Copy link
Contributor

shipit

@yuandongx
Copy link
Contributor Author

bot_status

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jul 25, 2019
@ansibot ansibot merged commit 585128e into ansible:devel Jul 25, 2019
abadger pushed a commit that referenced this pull request Jul 30, 2019
* ce_mlag_config: update to fix a bug. (#59336)

* update to fix a bug.

* update

* Update ce_mlag_config.py

* Update ce_mlag_config.py

(cherry picked from commit 585128e)

* add a changelog fragment.
@ansible ansible locked and limited conversation to collaborators Aug 22, 2019
@yuandongx yuandongx deleted the bug/ce_mlag_config/20190720 branch September 24, 2019 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants