Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ce_stp: update to fix a bug. #59347

Merged
merged 3 commits into from Jul 26, 2019
Merged

ce_stp: update to fix a bug. #59347

merged 3 commits into from Jul 26, 2019

Conversation

yuandongx
Copy link
Contributor

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/network/cloudengine/ce_stp.py

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 21, 2019

cc @QijunPan @TommyLike @edisonxiang @freesky-edward @hwDCN @niuzhenguo @zengchen1024 @zhongjun2
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 21, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 21, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_stp.py:247:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with the error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc -t module ce_stp" returned exit status 0.
>>> Standard Error
<unknown>:247: SyntaxWarning: invalid escape sequence \s

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_stp.py:247:0: SyntaxWarning: invalid escape sequence \s

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_stp.py:247:56: W605 invalid escape sequence '\s'

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 21, 2019
@yuandongx yuandongx marked this pull request as ready for review July 24, 2019 06:38
@yuandongxx
Copy link
Contributor

shipit

@yuandongx
Copy link
Contributor Author

bot_status

1 similar comment
@yuandongx
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jul 26, 2019

Components

lib/ansible/modules/network/cloudengine/ce_stp.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): hwDCN xuxiaowei0512
shipit_actors_other: []
automerge: automerge tests passed

click here for bot help

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jul 26, 2019
@ansibot ansibot merged commit c3d1f9b into ansible:devel Jul 26, 2019
abadger pushed a commit that referenced this pull request Jul 30, 2019
@yuandongx @abadger
Backport/2.8/59347 ce_stp: update to fix a bug. (#59347) (#59685)
8badf3b 
* ce_stp: update to fix a bug. (#59347)

* update to fix a bug.

* update for shippable.

* Update ce_stp.py

(cherry picked from commit c3d1f9b)

* add a changelog fragment.

* Update 59685-ce_stp-to-fix-bugs.yml
@ansible ansible locked and limited conversation to collaborators Aug 26, 2019
@yuandongx yuandongx deleted the bug/ce_stp/20190721 branch September 16, 2019 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuandongx @ansibot @yuandongxx