Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ce_sflow: update to fix bugs. #59349

Merged
merged 11 commits into from
Sep 24, 2019
Merged

ce_sflow: update to fix bugs. #59349

merged 11 commits into from
Sep 24, 2019

Conversation

yuandongx
Copy link
Contributor

SUMMARY

ce_sflow: update to fix bugs.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/network/cloudengine/ce_sflow.py

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 21, 2019

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ImportError: No module named ncclient.xml_

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ImportError: No module named ncclient.xml_

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ImportError: No module named 'ncclient'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ModuleNotFoundError: No module named 'ncclient'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ModuleNotFoundError: No module named 'ncclient'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ModuleNotFoundError: No module named 'ncclient'

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 21, 2019

cc @QijunPan @TommyLike @edisonxiang @freesky-edward @hwDCN @niuzhenguo @zengchen1024 @zhongjun2
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 21, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 29, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 5, 2019

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ImportError: No module named ncclient.xml_

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ImportError: No module named ncclient.xml_

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ImportError: No module named 'ncclient'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ModuleNotFoundError: No module named 'ncclient'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ModuleNotFoundError: No module named 'ncclient'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ModuleNotFoundError: No module named 'ncclient'

click here for bot help

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 5, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 13, 2019
@yuandongx yuandongx marked this pull request as ready for review September 16, 2019 02:16
@yuandongx yuandongx closed this Sep 16, 2019
@yuandongx yuandongx deleted the bug/ce_sflow/20190721 branch September 16, 2019 09:19
@yuandongx yuandongx restored the bug/ce_sflow/20190721 branch September 16, 2019 09:22
@yuandongx yuandongx reopened this Sep 16, 2019
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 16, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 16, 2019

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ImportError: No module named ncclient.xml_

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ImportError: No module named ncclient.xml_

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ImportError: No module named 'ncclient'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ModuleNotFoundError: No module named 'ncclient'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ModuleNotFoundError: No module named 'ncclient'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:207:0: ModuleNotFoundError: No module named 'ncclient'

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Sep 16, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 19, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_sflow.py:401:19: undefined-variable: Undefined variable 'get_nc_config'

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Sep 19, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 19, 2019
@yuandongx
Copy link
Contributor Author

-label affects_2.9
+label affects_2.10

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 and removed affects_2.9 This issue/PR affects Ansible v2.9 labels Sep 24, 2019
@yuandongxx
Copy link
Contributor

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Sep 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 24, 2019

Components

lib/ansible/modules/network/cloudengine/ce_sflow.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): hwDCN xuxiaowei0512
shipit_actors_other: []
automerge: automerge tests passed

click here for bot help

@ansibot ansibot merged commit 7711524 into ansible:devel Sep 24, 2019
@yuandongx yuandongx deleted the bug/ce_sflow/20190721 branch September 24, 2019 09:52
@ansible ansible locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuandongx @ansibot @yuandongxx