Add hcloud_network module #59366

LKaemmerling · 2019-07-22T05:19:35Z

SUMMARY

This adds the first of our Network modules for Ansible 2.9.

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

hcloud_network

ADDITIONAL INFORMATION

ansibot · 2019-07-22T05:23:49Z

cc @cschmitt-hcloud @mattclay
click here for bot help

ansibot · 2019-07-22T05:42:46Z

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ImportError: No module named hcloud

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ImportError: No module named hcloud

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ImportError: No module named 'hcloud'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ModuleNotFoundError: No module named 'hcloud'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ModuleNotFoundError: No module named 'hcloud'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ModuleNotFoundError: No module named 'hcloud'

The test ansible-test sanity --test test-constraints [explain] failed with 1 error:

test/runner/requirements/integration.cloud.hcloud.txt:1:7: put constraints in `test/runner/requirements/constraints.txt`

click here for bot help

LKaemmerling · 2019-07-29T06:54:32Z

@mattclay i guess for getting the test running you need to rebuild the testcontainer or am i wrong?

Our hcloud-python now officially support python 3.8.

ansibot · 2019-07-29T07:08:07Z

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ImportError: No module named hcloud

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ImportError: No module named hcloud

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ImportError: No module named 'hcloud'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ModuleNotFoundError: No module named 'hcloud'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ModuleNotFoundError: No module named 'hcloud'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ModuleNotFoundError: No module named 'hcloud'

The test ansible-test sanity --test test-constraints [explain] failed with 1 error:

test/runner/requirements/integration.cloud.hcloud.txt:1:7: put constraints in `test/runner/requirements/constraints.txt`

click here for bot help

ansibot · 2019-07-29T07:18:46Z

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ImportError: No module named hcloud

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ImportError: No module named hcloud

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ImportError: No module named 'hcloud'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ModuleNotFoundError: No module named 'hcloud'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ModuleNotFoundError: No module named 'hcloud'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_network.py:112:0: ModuleNotFoundError: No module named 'hcloud'

The test ansible-test sanity --test test-constraints [explain] failed with 1 error:

test/runner/requirements/integration.cloud.hcloud.txt:1:7: put constraints in `test/runner/requirements/constraints.txt`

click here for bot help

ghost

LGTM

lib/ansible/modules/cloud/hcloud/hcloud_network.py

test/runner/requirements/integration.cloud.hcloud.txt

Co-Authored-By: Matt Clay <matt@mystile.com>

ghost · 2019-07-30T05:50:22Z

shipit

LKaemmerling · 2019-07-30T05:57:31Z

/cc @resmo

lib/ansible/modules/cloud/hcloud/hcloud_network.py

felixfontein · 2019-07-30T08:32:23Z

lib/ansible/modules/cloud/hcloud/hcloud_network.py

+    id:
+        description:
+            - The ID of the Hetzner Cloud Networks to manage.
+            - Only required if no Network I(name) is given


One thing that would be noteworthy to users: if the user specifies both id and name during creation, the network will not necessarily have the ID the user specified.

I'm not really sure if we need to handle this, because we don't handle this in the other modules as well.

It would mostly reduce the potential number of support queries when users wonder why something is not working from their POV ;-) Feel free to ignore this; I'm mostly pointing out what I would be wondering about if I would be a user of the module :-)

test/integration/targets/hcloud_network/tasks/main.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

felixfontein · 2019-07-30T09:50:25Z

It looks like the tests failed because the network shippable-134407-132-integ already exists?!

It's probably best to make sure at the beginning of the tests that the network doesn't exist. (And to clean up with a block/always construct so that the network is also removed if execution of the tests fail somewhere inbetween.)

LKaemmerling · 2019-07-30T09:55:31Z

It looks like the tests failed because the network shippable-134407-132-integ already exists?!

It's probably best to make sure at the beginning of the tests that the network doesn't exist. (And to clean up with a block/always construct so that the network is also removed if execution of the tests fail somewhere inbetween.)

Already working on it :)

ghost

LGTM

felixfontein · 2019-07-30T12:00:15Z

LGTM as well!

felixfontein · 2019-07-30T12:00:46Z

Thanks for creating this module!

Add hcloud_network module

be9eb47

ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 22, 2019

bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 23, 2019

hoerup mentioned this pull request Jul 25, 2019

hcloud_server: add private network options #59133

Closed

LKaemmerling closed this Jul 29, 2019

LKaemmerling reopened this Jul 29, 2019

ansibot added has_issue and removed ci_verified Changes made in this PR are causing tests to fail. labels Jul 29, 2019

ghost approved these changes Jul 29, 2019

View reviewed changes

mattclay reviewed Jul 29, 2019

View reviewed changes

lib/ansible/modules/cloud/hcloud/hcloud_network.py Outdated Show resolved Hide resolved

test/runner/requirements/integration.cloud.hcloud.txt Outdated Show resolved Hide resolved

LKaemmerling and others added 2 commits July 30, 2019 06:31

Apply suggestions from code review

18f1850

Co-Authored-By: Matt Clay <matt@mystile.com>

Add notice about dependency

71322b5

ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Jul 30, 2019

ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 30, 2019

felixfontein reviewed Jul 30, 2019

View reviewed changes

Apply suggestions from code review

7f0cfc1

Co-Authored-By: Felix Fontein <felix@fontein.de>

LKaemmerling added 2 commits July 30, 2019 12:11

Allow changing of ip range

ed8085c

Add Setup step

1203023

LKaemmerling closed this Jul 30, 2019

LKaemmerling reopened this Jul 30, 2019

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 30, 2019

ghost approved these changes Jul 30, 2019

View reviewed changes

ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 30, 2019

felixfontein merged commit 5bddd2f into ansible:devel Jul 30, 2019

LKaemmerling deleted the add-hcloud_network branch July 30, 2019 12:03

This was referenced Jul 30, 2019

Add basic hcloud_subnetwork module #59781

Merged

Add basic hcloud_route module #59908

Merged

Add hcloud_server_network module #60061

Merged

ansible locked and limited conversation to collaborators Aug 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add hcloud_network module #59366

Add hcloud_network module #59366

LKaemmerling commented Jul 22, 2019 •

edited

ansibot commented Jul 22, 2019

ansibot commented Jul 22, 2019

LKaemmerling commented Jul 29, 2019

ansibot commented Jul 29, 2019

ansibot commented Jul 29, 2019

ghost left a comment

ghost commented Jul 30, 2019

LKaemmerling commented Jul 30, 2019

felixfontein Jul 30, 2019

LKaemmerling Jul 30, 2019

felixfontein Jul 30, 2019

felixfontein commented Jul 30, 2019

LKaemmerling commented Jul 30, 2019

ghost left a comment

felixfontein commented Jul 30, 2019

felixfontein commented Jul 30, 2019

Add hcloud_network module #59366

Add hcloud_network module #59366

Conversation

LKaemmerling commented Jul 22, 2019 • edited

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibot commented Jul 22, 2019

ansibot commented Jul 22, 2019

LKaemmerling commented Jul 29, 2019

ansibot commented Jul 29, 2019

ansibot commented Jul 29, 2019

ghost left a comment

Choose a reason for hiding this comment

ghost commented Jul 30, 2019

LKaemmerling commented Jul 30, 2019

felixfontein Jul 30, 2019

Choose a reason for hiding this comment

LKaemmerling Jul 30, 2019

Choose a reason for hiding this comment

felixfontein Jul 30, 2019

Choose a reason for hiding this comment

felixfontein commented Jul 30, 2019

LKaemmerling commented Jul 30, 2019

ghost left a comment

Choose a reason for hiding this comment

felixfontein commented Jul 30, 2019

felixfontein commented Jul 30, 2019

LKaemmerling commented Jul 22, 2019 •

edited