Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rds: add point-in-time instance restore test #59411

Merged
merged 1 commit into from
Jul 25, 2019
Merged

rds: add point-in-time instance restore test #59411

merged 1 commit into from
Jul 25, 2019

Conversation

willthames
Copy link
Contributor

SUMMARY

I thought I'd found a bug in point-in-time instance restore but my test suite could not reproduce it (I think it might be due to a botocore version so old it should be updated anyway). The resulting test suite should be useful nonetheless

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

rds_instance

@ansibot
Copy link
Contributor

ansibot commented Jul 23, 2019

cc @s-hertel
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cloud core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 23, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 23, 2019

cc @s-hertel
click here for bot help

@willthames
Copy link
Contributor Author

Found the issue that caused my problems, unrelated to botocore (a badly locally patched version of rds_instance.py) but the test suite is still a worthy outcome

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 23, 2019
jillr
jillr approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests pass for me, thanks willthames.

@s-hertel s-hertel merged commit 60c76be into ansible:devel Jul 25, 2019
@ansible ansible locked and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jillr jillr jillr approved these changes

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 cloud core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@willthames @ansibot @jillr @s-hertel @bcoca