Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meraki_organization - Add deletion support #59415

Merged
merged 2 commits into from
Jul 31, 2019
Merged

meraki_organization - Add deletion support #59415

merged 2 commits into from
Jul 31, 2019

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Jul 23, 2019 •
edited

SUMMARY

Meraki added support for deleting organizations (yay!). This PR adds support for organization deletion.

This PR also restructures the integration tests to be in a separate file from main.yml.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

meraki_organization

ADDITIONAL INFORMATION
TASK [meraki_organization : Delete cloned organizations with check mode] *******
changed: [localhost]

TASK [meraki_organization : assert] ********************************************
ok: [localhost] => changed=false
  msg: All assertions passed

TASK [meraki_organization : Delete cloned organizations] ***********************
changed: [localhost]

TASK [meraki_organization : Delete renamed organization by id] *****************
changed: [localhost]

@kbreit kbreit mentioned this pull request Jul 23, 2019
Closed
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. has_issue meraki Cisco Meraki community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Jul 23, 2019
@kbreit kbreit changed the title meraki_organziation - Add deletion support meraki_organization - Add deletion support Jul 23, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 24, 2019
@Qalthos Qalthos merged commit 516b39b into ansible:devel Jul 31, 2019
@ansible ansible locked and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@pabelanger pabelanger pabelanger approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. has_issue meraki Cisco Meraki community module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kbreit @Qalthos @pabelanger @ansibot