Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcp_utils: Handle JSON decode exception #59427

Merged
merged 1 commit into from
Jul 26, 2019
Merged

gcp_utils: Handle JSON decode exception #59427

merged 1 commit into from
Jul 26, 2019

Conversation

Akasurde
Copy link
Member

SUMMARY

Handle json.loads exception rather than providing stacktrace

Fixes: #56269

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/gcp_utils.py

@Akasurde
gcp_utils: Handle JSON decode exception
642a3b4 
Handle json.loads exception rather than providing stacktrace

Fixes: ansible#56269

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this pull request Jul 23, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Jul 23, 2019

cc @erjohnso @rambleraptor
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. has_issue needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 23, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 23, 2019

cc @erjohnso @rambleraptor
click here for bot help

Andersson007
Andersson007 approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shipit

@Akasurde Akasurde merged commit c1ee1f1 into ansible:devel Jul 26, 2019
@Akasurde Akasurde deleted the i56269 branch July 26, 2019 06:01
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 30, 2019
@ansible ansible locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. has_issue support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gcp_storage_object fails with service_account_contents option
4 participants
@Akasurde @ansibot @Andersson007 @sivel