Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify type-str for common NetApp E-Series documention options. #59459

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Specify type-str for common NetApp E-Series documention options. #59459

merged 1 commit into from
Jul 23, 2019

Conversation

ndswartz
Copy link
Contributor

SUMMARY

In the netapp.py module documentation the NetApp E-Series options were missing type specifications.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

netapp

ADDITIONAL INFORMATION
ansible 2.9.0.dev0
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/home/swartzn/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/swartzn/projects/ansible/ansible/lib/ansible
  executable location = /home/swartzn/projects/ansible/ansible/bin/ansible
  python version = 3.6.7 (default, Oct 22 2018, 11:32:17) [GCC 8.2.0]

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jul 23, 2019
@acozine
Copy link
Contributor

acozine commented Jul 23, 2019

@ndswartz thanks for updating the Ansible docs.

Now that you've fixed a mismatch between the documentation and the argspec, you need to remove this module from the list of mismatches to ignore (code here) - until you do, this PR will fail CI.

Full error message is:

 test/sanity/validate-modules/ignore.txt:3459:1: A102 
Remove since "lib/ansible/modules/storage/netapp/netapp_e_volume_copy.py" passes "E338" test

@ansibot
Copy link
Contributor

ansibot commented Jul 23, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:3459:1: A102 Remove since "lib/ansible/modules/storage/netapp/netapp_e_volume_copy.py" passes "E338" test

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 23, 2019
@ndswartz ndswartz force-pushed the netapp_eseries_documentation_dev branch from 9d0f9cb to a6b2fc9 Compare July 23, 2019 19:04
@ndswartz
Copy link
Contributor Author

8

I've updated the ignore.txt document.

@ansibot
Copy link
Contributor

ansibot commented Jul 23, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jul 23, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 23, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 23, 2019
@ndswartz
Copy link
Contributor Author

@acozine is there anything else I need to do?

@acozine
Copy link
Contributor

acozine commented Jul 23, 2019

Looks good, thanks @ndswartz.

@acozine acozine merged commit 6a77533 into ansible:devel Jul 23, 2019
@ndswartz
Copy link
Contributor Author

@acozine Thanks

@ndswartz ndswartz deleted the netapp_eseries_documentation_dev branch July 23, 2019 19:39
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 24, 2019
@ansible ansible locked and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ndswartz @acozine @ansibot @sivel @swartzn