Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix py3 decoding issues in cyberarkpassword.py #59500

Merged
merged 4 commits into from
Jul 31, 2019
Merged

Fix py3 decoding issues in cyberarkpassword.py #59500

merged 4 commits into from
Jul 31, 2019

Conversation

mback2k
Copy link
Contributor

@mback2k mback2k commented Jul 24, 2019 •
edited

SUMMARY

This commit fixes the following error while using Python 3:

ERROR! Unexpected Exception, this is probably a bug: a bytes-like object is required, not 'str'

Fixes #52625

Please backport this change to all still supported Ansible versions.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cyberarkpassword lookup plugin

@mback2k
Fix py3 decoding issues in cyberarkpassword.py
29ebc13 
This commit fixes the following error while using Python 3:

ERROR! Unexpected Exception, this is probably a bug: a bytes-like object is required, not 'str'
@ansibot
Copy link
Contributor

ansibot commented Jul 24, 2019

cc @cyberark-bizdev
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. python3 small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jul 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 24, 2019

cc @cyberark-bizdev
click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 24, 2019
@Akasurde Akasurde mentioned this pull request Jul 24, 2019
Closed
@Akasurde Akasurde self-assigned this Jul 24, 2019
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jul 24, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed small_patch needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 24, 2019
@mback2k
Copy link
Contributor Author

mback2k commented Jul 25, 2019

@Akasurde Are my changes sufficient for a merge?

@Akasurde
Copy link
Member

@mback2k LGTM. Need additional pair of eyes to take a look. @maxamillion @samdoran @mkrizek Can someone review this ? Thanks in advance.

@mkrizek mkrizek requested a review from webknjaz July 30, 2019 05:32
@mback2k
Copy link
Contributor Author

mback2k commented Jul 30, 2019

@samdoran Thanks for your review, I just pushed a new commit to this PR to address it.

@mback2k
Copy link
Contributor Author

mback2k commented Jul 30, 2019 •
edited

I think the errors in the latest Shippable check run are unrelated, but instead related to ansible module podman. Could you please retrigger it? See the following error messages:

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 30, 2019
@Akasurde
Copy link
Member

Akasurde commented Jul 30, 2019 •
edited

@mback2k I raised a PR to disable unstable tests #59763 once that is merged, I will re-trigger the CI for this PR. Merged #59763

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 30, 2019
Akasurde
Akasurde approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akasurde Akasurde requested a review from samdoran July 30, 2019 11:58
samdoran
samdoran approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please create a changelog fragment and we can merge this. See this fragment as an example.

@mback2k
Copy link
Contributor Author

mback2k commented Jul 31, 2019

@samdoran Thanks, I just created the requested changelog fragment.

@Akasurde Akasurde merged commit 98df8e0 into ansible:devel Jul 31, 2019
@Akasurde
Copy link
Member

@mback2k Thanks for the contribution. @samdoran Thanks for review.

@ansible ansible locked and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde approved these changes

@samdoran samdoran samdoran approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz

Assignees

@Akasurde Akasurde

Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. has_issue new_contributor This PR is the first contribution by a new community member. python3 support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cyberarkpassword: TypeError: a bytes-like object is required, not 'str'
4 participants
@mback2k @ansibot @Akasurde @samdoran