prevent recursive logging csharp stackoverflow. #59503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nznobody
changed the title
ansibot
added
affects_2.9
|
Bump? This is a simple fix, would be great to have it in please! @jborean93 |
jborean93
approved these changes
Jul 28, 2019
|
Are you able to create a changelog fragment like https://github.com/ansible/ansible/blob/devel/changelogs/fragments/51995-apt_repository-catch-IOError.yaml. We require a changelog fragment to be able to backport modules to older branches. |
ansibot
removed
the
needs_triage
|
Yup, hopefully that suits. Do you need a rebase & squash or good as is? Cheers for the quick response :) |
ansibot
added
support:community
|
bump @nitzmahone, have done the change log fragment too |
jborean93
approved these changes
Jul 30, 2019
|
Sorry for the CI struggles there, looks good. Are you able to backport the PR to stable-2.8 so it's included in the next 2.8 release https://docs.ansible.com/ansible/latest/community/development_process.html#backporting-merged-prs. |
|
Thanks @jborean93 ! Done: #60267 |
abadger
pushed a commit
that referenced
this pull request
Aug 9, 2019
* prevent recursive logging situation. * Add changelog (cherry picked from commit 6a5cd9a)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Simple bugfix to avoid recursive function calls in C# code causing Stack overflow on windows / powershell. Note the already present [comment].(
ansible/lib/ansible/module_utils/csharp/Ansible.Basic.cs
Line 325 in 5228133
ISSUE TYPE
COMPONENT NAME
ansible.basics (core C#)
ADDITIONAL INFORMATION
To reproduce:
Call
win_pingviavmware_toolsconnection plugin. It will crash powershell and hang (whilst WerFault.exe dumps proc).vmware_toolsdoes not support privilege escalation and so the line:EventLog.CreateEventSource(logSource, "Application");fails and we get into a cycle.