Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail earlier if junos_ping is used with connection netconf #59534

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Fail earlier if junos_ping is used with connection netconf #59534

merged 1 commit into from
Jul 24, 2019

Conversation

NilashishC
Copy link
Contributor

Signed-off-by: NilashishC nilashishchakraborty8@gmail.com

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

junos_ping.py

@NilashishC
junos_ping supports only network_cli
ff5cb58 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@ansibot
Copy link
Contributor

ansibot commented Jul 24, 2019

cc @Qalthos @danielmellado @ganeshrn @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jul 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 24, 2019

cc @Qalthos @danielmellado @ganeshrn @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansible-zuul
Copy link

ansible-zuul bot commented Jul 24, 2019

Build succeeded (third-party-check pipeline).

@NilashishC NilashishC merged commit 119f2b8 into ansible:devel Jul 24, 2019
@NilashishC NilashishC deleted the junos_ping_fix branch July 24, 2019 17:41
@ansible ansible locked and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

junos_ping fail when using netconf connection plugin
3 participants
@NilashishC @ansibot @Qalthos