Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers in URL lookup plugin #59555

Merged
merged 7 commits into from
Jul 31, 2019
Merged

Headers in URL lookup plugin #59555

merged 7 commits into from
Jul 31, 2019

Conversation

glyngholm
Copy link
Contributor

Allow use of request headers in URL lookup plugin

SUMMARY

Allows passing of host headers to URL lookup plugin.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lookup: url

ADDITIONAL INFORMATION

Allowing host headers to be passed to URL lookup module would allow for easier integration with web-based APIs.

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 24, 2019

The test ansible-test sanity --test changelog [explain] failed with 1 error:

changelogs/fragments/59555-lookup-url-headers.yaml:0:0: section "minor_changes" must be type list not str

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 24, 2019

The test ansible-test sanity --test changelog [explain] failed with 1 error:

changelogs/fragments/59555-lookup-url-headers.yaml:0:0: section "minor_changes" must be type list not str

click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 24, 2019
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jul 30, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 30, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 30, 2019

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 1 error:

test/integration/targets/elb_target/playbooks/roles/elb_lambda_target/files/ansible_lambda_target.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 1 error:

test/integration/targets/elb_target/playbooks/roles/elb_lambda_target/files/ansible_lambda_target.py:0:0: missing: __metaclass__ = type

click here for bot help

1 similar comment
@ansibot
Copy link
Contributor

ansibot commented Jul 30, 2019

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 1 error:

test/integration/targets/elb_target/playbooks/roles/elb_lambda_target/files/ansible_lambda_target.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 1 error:

test/integration/targets/elb_target/playbooks/roles/elb_lambda_target/files/ansible_lambda_target.py:0:0: missing: __metaclass__ = type

click here for bot help

@bcoca bcoca merged commit f46eb8e into ansible:devel Jul 31, 2019
@ansible ansible locked and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 feature This issue/PR relates to a feature request. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glyngholm @ansibot @bcoca @samdoran