Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOS-XR: Handle lowercase in version info #59565

Merged
merged 1 commit into from
Jul 25, 2019
Merged

IOS-XR: Handle lowercase in version info #59565

merged 1 commit into from
Jul 25, 2019

Conversation

NilashishC
Copy link
Contributor

Signed-off-by: NilashishC nilashishchakraborty8@gmail.com

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cliconf/iosxr.py

@NilashishC
Handle lowercase in version info
a1c35a1 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC NilashishC requested a review from justjais July 25, 2019 04:36
@NilashishC NilashishC mentioned this pull request Jul 25, 2019
Merged
@ansibot
Copy link
Contributor

ansibot commented Jul 25, 2019

cc @Qalthos @danielmellado @ganeshrn @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. iosxr Cisco IOSXR community needs_triage Needs a first human triage before being processed. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jul 25, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 25, 2019

cc @Qalthos @danielmellado @ganeshrn @justjais @rcarrillocruz @trishnaguha
click here for bot help

justjais
justjais approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@justjais justjais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm +1

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Jul 25, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Jul 25, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@NilashishC
Copy link
Contributor Author

Looks like Zuul is failing because of infra issue.

@NilashishC
Copy link
Contributor Author

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Jul 25, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@NilashishC
Copy link
Contributor Author

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Jul 25, 2019

Build succeeded (third-party-check pipeline).

@NilashishC NilashishC merged commit 3a10340 into ansible:devel Jul 25, 2019
@NilashishC NilashishC deleted the iosxr_cliconf branch July 25, 2019 17:36
NilashishC pushed a commit to NilashishC/ansible that referenced this pull request Jul 26, 2019
@justjais @NilashishC
PR to implement ansible_net_model for iosxr facts module (ansible#58488)
268e1c1 
* resolves 57767

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* added test

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 539f37e)

Handle lowercase in version info (ansible#59565)

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit 3a10340)

Add changelog for iosxr_facts fix

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC NilashishC mentioned this pull request Jul 26, 2019
Merged
abadger pushed a commit that referenced this pull request Jul 30, 2019
@justjais @abadger
PR to implement ansible_net_model for iosxr facts module (#58488)
35ba555 
* resolves 57767

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* added test

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 539f37e)

Handle lowercase in version info (#59565)

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit 3a10340)

Add changelog for iosxr_facts fix

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@pabelanger pabelanger mentioned this pull request Jul 31, 2019
Closed
@ansible ansible locked and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justjais justjais justjais approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cisco Cisco technologies iosxr Cisco IOSXR community networking Network category shipit This PR is ready to be merged by Core small_patch support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NilashishC @ansibot @justjais