Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support creating an image from a volume #59574

Merged
merged 5 commits into from
Sep 27, 2019
Merged

support creating an image from a volume #59574

merged 5 commits into from
Sep 27, 2019

Conversation

bverschueren
Copy link
Contributor

SUMMARY

Support creating an image from a volume

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

os_image

@ansibot
Copy link
Contributor

ansibot commented Jul 25, 2019

cc @Shrews @cloudnull @dagnello @emonty @gtema @juliakreger @mnaser @odyssey4me @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. openstack support:community This issue/PR relates to code supported by the Ansible community. labels Jul 25, 2019
@opendev-zuul
Copy link

opendev-zuul bot commented Jul 25, 2019

Build succeeded (third-party-check pipeline).

jamescassell
jamescassell approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@jamescassell jamescassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

lib/ansible/modules/cloud/openstack/os_image.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 1, 2019
@bverschueren bverschueren reopened this Aug 2, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 2, 2019
@opendev-zuul
Copy link

opendev-zuul bot commented Aug 2, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 10, 2019
cloudnull
cloudnull suggested changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@cloudnull cloudnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Aug 23, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 27, 2019
@opendev-zuul
Copy link

opendev-zuul bot commented Aug 27, 2019

Build succeeded (third-party-check pipeline).

@bverschueren bverschueren reopened this Sep 3, 2019
@opendev-zuul
Copy link

opendev-zuul bot commented Sep 3, 2019

Build succeeded (third-party-check pipeline).

@ansibot
Copy link
Contributor

ansibot commented Sep 3, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_image.py:0:0: option-incorrect-version-added: version_added for new option (volume) should be '2.10'. Currently StrictVersion ('2.9')

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Sep 3, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 3, 2019
@opendev-zuul
Copy link

opendev-zuul bot commented Sep 3, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 4, 2019
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Sep 14, 2019
@bverschueren
Copy link
Contributor Author

ready_for_review

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 19, 2019
cloudnull
cloudnull approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@cloudnull cloudnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot removed the stale_review Updates were made after the last review and the last review is more than 7 days old. label Sep 23, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 27, 2019
@opendev-zuul
Copy link

opendev-zuul bot commented Sep 27, 2019

Build succeeded (third-party-check pipeline).

@felixfontein felixfontein merged commit c3eceb3 into ansible:devel Sep 27, 2019
@felixfontein
Copy link
Contributor

@bverschueren thanks for implementing this!
@cloudnull @jamescassell thanks for reviewing!

@bverschueren bverschueren deleted the os_image_from_volume branch September 27, 2019 14:01
@ansible ansible locked and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cloudnull cloudnull cloudnull approved these changes

@jamescassell jamescassell jamescassell approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. openstack support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bverschueren @ansibot @felixfontein @cloudnull @jamescassell