Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql_set: improve CI tests #59583

Merged
merged 1 commit into from
Jul 26, 2019
Merged

postgresql_set: improve CI tests #59583

merged 1 commit into from
Jul 26, 2019

Conversation

Andersson007
Copy link
Contributor

SUMMARY

postgresql_set: improve CI tests

  1. improve formatting
  2. add additional checks by SQL queries
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

postgresql_set

@Andersson007 Andersson007 reopened this Jul 25, 2019
@Andersson007 Andersson007 reopened this Jul 25, 2019
@Andersson007 Andersson007 reopened this Jul 25, 2019
@Andersson007 Andersson007 reopened this Jul 25, 2019
@Andersson007 Andersson007 reopened this Jul 25, 2019
@Andersson007
Copy link
Contributor Author

+label: postgresql

@Andersson007 Andersson007 reopened this Jul 25, 2019
@Andersson007
Copy link
Contributor Author

+label postgresql

@Andersson007 Andersson007 reopened this Jul 25, 2019
@Andersson007 Andersson007 force-pushed the postgresql_set_ci_add_additional_checks branch 6 times, most recently from 5555bc7 to fc43d5a Compare July 25, 2019 13:40
@ansibot
Copy link
Contributor

ansibot commented Jul 25, 2019

cc @Dorn- @amenonsen @andytom @jbscalia @kostiantyn-nemchenko @kustodian @matburt @nerzhul @sebasmannem @tcraxs
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Jul 25, 2019
@Andersson007 Andersson007 changed the title [WIP] postgresql_set: improve CI tests postgresql_set: improve CI tests Jul 25, 2019
@Andersson007 Andersson007 force-pushed the postgresql_set_ci_add_additional_checks branch from fc43d5a to a12ca4f Compare July 25, 2019 13:55
@ansibot
Copy link
Contributor

ansibot commented Jul 25, 2019

cc @Dorn- @amenonsen @andytom @jbscalia @kostiantyn-nemchenko @kustodian @matburt @nerzhul @sebasmannem @tcraxs
click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Jul 25, 2019
@Andersson007
Copy link
Contributor Author

I need to go. All is OK, I'll rebase it tomorrow

@Andersson007
Copy link
Contributor Author

ready_for_review

@Andersson007 Andersson007 force-pushed the postgresql_set_ci_add_additional_checks branch from a12ca4f to 82a48c4 Compare July 26, 2019 13:23
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 26, 2019
@Andersson007 Andersson007 force-pushed the postgresql_set_ci_add_additional_checks branch from 82a48c4 to f7dc8e0 Compare July 26, 2019 13:35
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 26, 2019
@felixfontein felixfontein merged commit 5b1a4f9 into ansible:devel Jul 26, 2019
@felixfontein
Copy link
Contributor

@Andersson007 thanks for improving the tests!

@Andersson007
Copy link
Contributor Author

@felixfontein , thank you for reviewing and merging!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 30, 2019
@ansible ansible locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Andersson007 @ansibot @felixfontein @sivel