Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nxos_facts integration tests #59643

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Fix nxos_facts integration tests #59643

merged 1 commit into from
Jul 29, 2019

Conversation

pabelanger
Copy link
Contributor

SUMMARY

Fix nxos_facts integration testing

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_facts

ADDITIONAL INFORMATION

@pabelanger
Fix nxos_facts integration tests
ce520f6 
This was incorrectly asserting the result of previous nxos_facts task.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Jul 26, 2019

cc @GGabriele @chrisvanheuveln @jedelman8 @mikewiebe @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cisco Cisco technologies needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Jul 26, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 26, 2019

cc @GGabriele @chrisvanheuveln @jedelman8 @mikewiebe @rahushen @rcarrillocruz @trishnaguha
click here for bot help

trishnaguha
trishnaguha approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@trishnaguha trishnaguha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix Paul!

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Jul 29, 2019
@trishnaguha trishnaguha merged commit c562b53 into ansible:devel Jul 29, 2019
@ansible ansible locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pabelanger @ansibot @trishnaguha