Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests: remove unused imports #59740

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Unit tests: remove unused imports #59740

merged 1 commit into from
Jul 29, 2019

Conversation

Andersson007
Copy link
Contributor

SUMMARY

Removed unused imports from unit tests

ISSUE TYPE
  • Bugfix Pull Request

@ansibot
Copy link
Contributor

ansibot commented Jul 29, 2019

@Andersson007 This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Jul 29, 2019
felixfontein
felixfontein approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! All tests seem to still pass, so this should be fine :)

@felixfontein felixfontein merged commit 32de51a into ansible:devel Jul 29, 2019
@felixfontein
Copy link
Contributor

Thanks for doing this!

@Andersson007
Copy link
Contributor Author

@felixfontein , thanks for reviewing and merging !

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 30, 2019
@ansible ansible locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Andersson007 @ansibot @felixfontein @sivel