inventory: Handle IndexError while parsing limit file #59776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
bcoca
reviewed
Jul 30, 2019
lib/ansible/inventory/manager.py
Outdated
| @@ -69,9 +69,9 @@ def order_patterns(patterns): | |||
| pattern_intersection = [] | |||
| pattern_exclude = [] | |||
| for p in patterns: | |||
| if p[0] == "!": | |||
There was a problem hiding this comment.
instead of adding p on every condition, if not p: continue would shortcut the whole thing
bcoca
approved these changes
Jul 30, 2019
bcoca
removed
the
needs_triage
mkrizek
reviewed
Jul 30, 2019
lib/ansible/inventory/manager.py
Outdated
| @@ -69,9 +69,9 @@ def order_patterns(patterns): | |||
| pattern_intersection = [] | |||
| pattern_exclude = [] | |||
| for p in patterns: | |||
| if p[0] == "!": | |||
| if p and p[0] == "!": | |||
There was a problem hiding this comment.
@sivel So this was introduced in #58400 and there are more changes where we replaced startswith with checking the first index instead for perf purposes. I wonder if doing p and p[0] over startswith is still beneficial. Or, if we should filter empty patterns someplace up, in the code that calls this.
There was a problem hiding this comment.
@mkrizek see my comment above, checking if not p would still be a net gain
Handle IndexError exception raised while parsing the limit file. Fixes: ansible#59695 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ansibot
added
needs_revision
ansibot
added
core_review
bcoca
approved these changes
Jul 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Handle IndexError exception raised while parsing the limit file.
Fixes: #59695
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/limit_file_parsing.yml
lib/ansible/inventory/manager.py
test/integration/targets/inventory/runme.sh