Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing aws modules to aws module defaults group #59788

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Add missing aws modules to aws module defaults group #59788

merged 2 commits into from
Jul 31, 2019

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 30, 2019 •
edited

SUMMARY

Add missing aws modules to aws module defaults group

ISSUE TYPE

Bugfix Pull Request
Fixes #59787

COMPONENT NAME

lib/ansible/config/module_defaults.yml

ADDITIONAL INFORMATION

The following modules had no group defined:

  • aws_codecommit
  • aws_secret
  • aws_ses_rule_set
  • cloudformation_stack_set
  • ec2_metadata_facts
  • ec2_transit_gateway
  • elb_target_facts
  • iam_password_policy
  • redshift_cross_region_snapshots

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 30, 2019
@tremble tremble force-pushed the aws_defaults branch 2 times, most recently from b496ccc to 9f54b8d Compare July 31, 2019 08:31
@mscherer
Copy link
Contributor

shipit

@mscherer mscherer removed the needs_triage Needs a first human triage before being processed. label Jul 31, 2019
@mscherer
Copy link
Contributor

rebuild_merge

@mscherer
Copy link
Contributor

!needs_revision

s-hertel
s-hertel requested changes Jul 31, 2019
View reviewed changes
lib/ansible/config/module_defaults.yml Outdated Show resolved Hide resolved
lib/ansible/config/module_defaults.yml Outdated Show resolved Hide resolved
lib/ansible/config/module_defaults.yml Outdated Show resolved Hide resolved
@tremble
Copy link
Contributor Author

tremble commented Jul 31, 2019

ready_for_review

@s-hertel s-hertel merged commit c1e5758 into ansible:devel Jul 31, 2019
@s-hertel
Copy link
Contributor

Thanks @tremble!

@tremble tremble deleted the aws_defaults branch August 23, 2019 19:42
@ansible ansible locked and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iam_password_policy ignores group/aws module defaults
4 participants
@tremble @mscherer @s-hertel @ansibot