Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix podman_image integration tests #59805

Merged
merged 1 commit into from Jul 30, 2019
Merged

Fix podman_image integration tests #59805

merged 1 commit into from Jul 30, 2019

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Jul 30, 2019 •
edited

SUMMARY

Pin podman package at a specific version on RHEL 7 and RHEL8.

RHEL 8 is using 1.0.0 whereas RHEL 7 is getting podman from extras, which is pretty much always the latest upstream release. It looks like RHEL 7 has the latest version of the most recent two minor releases. I pinned RHEL 7 at 1.3.* just in case they don't keep exact minor releases in the repo to prevent this test from failing every time there is a point release.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/integration/targets/podman_image/

ADDITIONAL INFORMATION

The current test failure is due to a change in output in Podman 1.4.4. That will need to be fixed in the podman_image module.

RHEL 8.1 will include podman 1.4.

RHEL 7:

$ yum list --showduplicates podman
Loaded plugins: amazon-id, rhui-lb, search-disabled-repos
Installed Packages
podman.x86_64                        1.4.4-2.el7                                      @rhui-REGION-rhel-server-extras
Available Packages
podman.x86_64                        0.4.1-4.gitb51d327.el7                           rhui-REGION-rhel-server-extras
podman.x86_64                        0.6.1-3.git3e0ff12.el7                           rhui-REGION-rhel-server-extras
podman.x86_64                        0.7.3-1.git0791210.el7                           rhui-REGION-rhel-server-extras
podman.x86_64                        0.9.2-5.git37a2afe.el7_5                         rhui-REGION-rhel-server-extras
podman.x86_64                        0.10.1.3-1.gitdb08685.el7                        rhui-REGION-rhel-server-extras
podman.x86_64                        0.11.1.1-3.git594495d.el7                        rhui-REGION-rhel-server-extras
podman.x86_64                        0.12.1.2-2.git9551f6b.el7                        rhui-REGION-rhel-server-extras
podman.x86_64                        1.3.2-1.git14fdcd0.el7                           rhui-REGION-rhel-server-extras
podman.x86_64                        1.4.4-2.el7                                      rhui-REGION-rhel-server-extras

RHEL 8:

$ yum module list container-tools
Last metadata expiration check: 0:15:33 ago on Tue 30 Jul 2019 05:50:16 PM UTC.
Red Hat Enterprise Linux 8 for x86_64 - AppStream from RHUI (RPMs)
Name                  Stream          Profiles             Summary
container-tools       1.0 [e]         common [d] [i]       Common tools and dependencies for container runtimes
container-tools       rhel8 [d]       common [d]           Common tools and dependencies for container runtimes

Hint: [d]efault, [e]nabled, [x]disabled, [i]nstalled


$ yum list --showduplicates podman
Last metadata expiration check: 0:15:14 ago on Tue 30 Jul 2019 05:50:16 PM UTC.
Installed Packages
podman.x86_64            1.0.0-2.git921f98f.module+el8+2784+9a0c1dfe                 @rhui-rhel-8-appstream-rhui-rpms
Available Packages
podman.x86_64            1.0.0-2.git921f98f.module+el8.0.0+2956+30df4692             rhui-rhel-8-appstream-rhui-rpms
podman.x86_64            1.0.0-2.git921f98f.module+el8+2784+9a0c1dfe                 @rhui-rhel-8-appstream-rhui-rpms
podman.x86_64            1.0.0-2.git921f98f.module+el8+2784+9a0c1dfe                 rhui-rhel-8-appstream-rhui-rpms

@ansibot
Copy link
Contributor

ansibot commented Jul 30, 2019

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/podman_image/aliases:0:0: missing alias `shippable/posix/group[1-4]` or `unsupported`

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 30, 2019
@samdoran
Fix podman_image integration tests
727f55c 
Pin podman package at a specific version
@samdoran samdoran force-pushed the ci/podman-integration-tests branch from f87da2b to 727f55c Compare July 30, 2019 18:18
@samdoran samdoran merged commit 691976c into ansible:devel Jul 30, 2019
@samdoran samdoran deleted the ci/podman-integration-tests branch July 30, 2019 19:11
samdoran added a commit to samdoran/ansible that referenced this pull request Jul 30, 2019
@samdoran
[stable-2.8] Fix podman_image integration tests (ansible#59805)
f0b77a7 
Pin podman package at a specific version
(cherry picked from commit 691976c)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@samdoran samdoran mentioned this pull request Jul 30, 2019
Merged
abadger pushed a commit that referenced this pull request Jul 31, 2019
@samdoran @abadger
[stable-2.8] Fix podman_image integration tests (#59805)
ce59df0 
Pin podman package at a specific version
(cherry picked from commit 691976c)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 31, 2019
This was referenced Jul 31, 2019
Closed
Merged
@ansible ansible locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samdoran @ansibot @sivel