EnableUser command fails if no Enabled property is present

[billdodd]

SUMMARY

When using the EnableUser command, if the account being targeted does not have an Enabled property, the command may fail with a 400 Bad Request.

ISSUE TYPE

• Bug Report

COMPONENT NAME

redfish_command.py
redfish_utils.py

ANSIBLE VERSION

ansible 2.9.0.dev0
  config file = $HOME/.ansible.cfg
  configured module search path = ['$HOME/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = $HOME/Development/git/ansible/lib/ansible
  executable location = $HOME/Development/git/ansible/bin/ansible
  python version = 3.6.5 (default, Apr 25 2018, 14:26:36) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]

CONFIGURATION

[no output]

OS / ENVIRONMENT

Applies to Redfish OOB controllers.

STEPS TO REPRODUCE

Try to run the EnableUser command for an account that does not have the Enabled property.

---
- hosts: myhosts
  connection: local
  name: Enable User
  gather_facts: False

  vars:
  - account_username: user8

  tasks:

  - name: Enable user
    redfish_command:
      category: Accounts
      command: EnableUser
      baseuri: "{{ baseuri }}"
      username: "{{ username }}"
      password: "{{ password }}"
      account_username: "{{ account_username }}"

EXPECTED RESULTS

Command succeeds with changed=0.

ACTUAL RESULTS

Command fails with:

400 Bad Request

[ansibot]

Files identified in the description:

• lib/ansible/modules/remote_management/redfish/redfish_command.py
• lib/ansible/modules/remote_management/redfish/redfish_config.py
• lib/ansible/modules/remote_management/redfish/redfish_facts.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @jose-delarosa @mraineri @tomasg2012
click here for bot help

[mraineri]

General rule: if Enabled is not supported, the account is assumed to be enabled. No reason to ever try to PATCH the property on these systems.

[ansibot]

Files identified in the description:

• lib/ansible/modules/remote_management/redfish/redfish_command.py
• lib/ansible/modules/remote_management/redfish/redfish_config.py
• lib/ansible/modules/remote_management/redfish/redfish_info.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help