Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve checking for unusable sanity test ignores. #59833

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Improve checking for unusable sanity test ignores. #59833

merged 2 commits into from
Jul 31, 2019

Conversation

mattclay
Copy link
Member

SUMMARY

Improve checking for unusable sanity test ignores.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ansible-test

@mattclay
Check sanity ignore paths against test paths.
358e509 
This prevents ignores from being added for paths which will never be tested by the test being ignored or skipped.
@mattclay
Fix sanity ignore handling for no/all targets.
dfebb15 
This allows checking of ignores for tests which do not use a target list.

It also allows checking of the full ignore list on every test run for tests that always use all targets.
@mattclay mattclay self-assigned this Jul 31, 2019
@mattclay mattclay added this to In progress in Testing Collections via automation Jul 31, 2019
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jul 31, 2019
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Jul 31, 2019
@mattclay mattclay merged commit 2198ecb into ansible:devel Jul 31, 2019
Testing Collections automation moved this from In progress to Done Jul 31, 2019
@mattclay mattclay deleted the sanity-unused-ignores branch July 31, 2019 01:58
@ansible ansible locked and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mattclay mattclay

Labels
affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
Testing Collections
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattclay @ansibot