gather_facts action plugin: Fix loading network facts modules for smart gathering #59856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoca
approved these changes
Jul 31, 2019
bcoca
requested changes
Jul 31, 2019
ansibot
added
affects_2.9
ansibot
added
the
stale_ci
|
@trishnaguha is this ready to merge? |
|
As beta1 is being released now, all future merges need to have changelog entries to tell users of pre-releases what has changed since beta1. This appears to be an approved bugfix which is eligible to be merged before rc1 but it does need to have the changelog added. |
trishnaguha
force-pushed
the
gather_facts_action_plugin
branch
from
d1fe9d6
to
551a5a5
Compare
ansibot
added
has_issue
new_plugin
trishnaguha
force-pushed
the
gather_facts_action_plugin
branch
from
551a5a5
to
5022437
Compare
|
@bcoca Will you please review the PR? We need this in 2.9. |
|
@bcoca bcoca says he's given a review of this via slack. So this is now waiting on changes from @trishnaguha |
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
trishnaguha
force-pushed
the
gather_facts_action_plugin
branch
from
5022437
to
e041b71
Compare
|
The PR now addresses the review comment. |
bcoca
approved these changes
Sep 17, 2019
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
trishnaguha
added a commit
to trishnaguha/ansible
that referenced
this pull request
Sep 17, 2019
…rt gathering (ansible#59856) * fix smart gathering for network_os in gather_facts action plugin Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * Fix detection of network_os for smart gathering Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * Add unittest Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * make pep8 happy Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 5cd3be9)
trishnaguha
added a commit
to trishnaguha/ansible
that referenced
this pull request
Sep 17, 2019
…rt gathering (ansible#59856) * fix smart gathering for network_os in gather_facts action plugin Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * Fix detection of network_os for smart gathering Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * Add unittest Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * make pep8 happy Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 5cd3be9)
abadger
pushed a commit
that referenced
this pull request
Sep 17, 2019
…rt gathering (#59856) * fix smart gathering for network_os in gather_facts action plugin Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * Fix detection of network_os for smart gathering Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * Add unittest Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * make pep8 happy Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 5cd3be9)
anas-shami
pushed a commit
to anas-shami/ansible
that referenced
this pull request
Sep 23, 2019
…rt gathering (ansible#59856) * fix smart gathering for network_os in gather_facts action plugin Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * Fix detection of network_os for smart gathering Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * Add unittest Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * make pep8 happy Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix loading network facts modules for smart gathering.
Currently the connection plugin is loaded but not the network_os which is why the <network_os>_facts module is not invoked.
ISSUE TYPE
COMPONENT NAME
plugins/action/gather_facts.py