Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Module: Volume Autosize #59936

Merged
merged 2 commits into from
Aug 14, 2019
Merged

New Module: Volume Autosize #59936

merged 2 commits into from
Aug 14, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

Volume Autosize module (For both Zapi and Rest)

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • na_ontap_volume_autosize.py
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 1, 2019

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 1 error:

test/units/modules/storage/netapp/test_na_ontap_volume_autosize.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 1 error:

test/units/modules/storage/netapp/test_na_ontap_volume_autosize.py:0:0: missing: __metaclass__ = type

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 1, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 ci_verified Changes made in this PR are causing tests to fail. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Aug 1, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 1, 2019

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 1 error:

test/units/modules/storage/netapp/test_na_ontap_volume_autosize.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 1 error:

test/units/modules/storage/netapp/test_na_ontap_volume_autosize.py:0:0: missing: __metaclass__ = type

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 1, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 1, 2019

@albinpopote @amit0701 @dprts @hulquest @lmprice @lonico @ndswartz @schmots1 @timuster @vicmunoz

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 1, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 1, 2019

@albinpopote @amit0701 @dprts @hulquest @lmprice @lonico @ndswartz @schmots1 @timuster @vicmunoz

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

lonico
lonico approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Aug 8, 2019
thedoubl3j
thedoubl3j approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs are clear, coverage is good. lgtm. shipit

@thedoubl3j thedoubl3j merged commit 206594c into ansible:devel Aug 14, 2019
@ansible ansible locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonico lonico lonico approved these changes

@anshulbehl anshulbehl anshulbehl approved these changes

@thedoubl3j thedoubl3j thedoubl3j approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 module This issue/PR relates to a module. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core storage support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carchi8py @ansibot @lonico @anshulbehl @thedoubl3j