Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for GCP (as of 2019-08-05T17:42:30Z) #60115

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Bug fixes for GCP (as of 2019-08-05T17:42:30Z) #60115

merged 1 commit into from
Aug 12, 2019

Conversation

modular-magician
Copy link
Contributor

SUMMARY

Bug fixes for GCP (as of 2019-08-05T17:42:30Z)
This PR is the result of the following Magic Modules PRs:

ISSUE TYPE
  • Bugfix Pull Request
ADDITIONAL INFORMATION
This was generated by [Magic Modules](https://github.com/googlecloudplatform/magic-modules)

@ansibot
Copy link
Contributor

ansibot commented Aug 5, 2019

cc @erjohnso @GoogleCloudPlatform @rambleraptor
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 5, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 5, 2019

cc @erjohnso @GoogleCloudPlatform @rambleraptor
click here for bot help

@rambleraptor
Copy link
Contributor

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 6, 2019
@rambleraptor
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Aug 9, 2019

Components

lib/ansible/module_utils/gcp_utils.py
support: community
maintainers: erjohnso rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_http_health_check_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_https_health_check_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_image_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_instance.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_instance_group_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_instance_group_manager_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_instance_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_instance_template_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/plugins/doc_fragments/gcp.py
support: community
maintainers: erjohnso rambleraptor

Metadata

waiting_on: modular-magician
changes_requested_by: null
needs_info: False
needs_revision: True
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: unstable
shippable_status: pending
maintainer_shipits (module maintainers): False
community_shipits (namespace maintainers): False
ansible_shipits (core team members): False
shipit_actors (maintainer or core team member): None
shipit_actors_other:
automerge: automerge shipit test failed

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 9, 2019

@modular-magician this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 9, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 9, 2019

Components

lib/ansible/module_utils/gcp_utils.py
support: community
maintainers: erjohnso rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_http_health_check_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_https_health_check_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_image_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_instance.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_instance_group_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_instance_group_manager_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_instance_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_instance_template_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/plugins/doc_fragments/gcp.py
support: community
maintainers: erjohnso rambleraptor

Metadata

waiting_on: modular-magician
changes_requested_by: null
needs_info: False
needs_revision: True
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: unstable
shippable_status: pending
maintainer_shipits (module maintainers): False
community_shipits (namespace maintainers): False
ansible_shipits (core team members): False
shipit_actors (maintainer or core team member): None
shipit_actors_other:
automerge: automerge shipit test failed

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 9, 2019

@modular-magician this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@rambleraptor
Copy link
Contributor

(Having an issue with our automated release pipeline! None of this will be getting merged in!)

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. test This PR relates to tests. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. labels Aug 9, 2019
@rambleraptor
Copy link
Contributor

This looks much more sane, so now it'll get merged in!

shipit

@modular-magician modular-magician force-pushed the bug_fixesmm-bugab branch 2 times, most recently from 3ef2752 to 45a2519 Compare August 11, 2019 06:05
@rambleraptor
Copy link
Contributor

bot_status

@rambleraptor
Copy link
Contributor

shipit

@ansibot
Copy link
Contributor

ansibot commented Aug 12, 2019

Components

lib/ansible/modules/cloud/google/gcp_compute_global_forwarding_rule.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_http_health_check.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_http_health_check_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_https_health_check.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_https_health_check_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_instance.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

test/integration/targets/gcp_compute_global_forwarding_rule/tasks/main.yml
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

test/integration/targets/gcp_compute_http_health_check/tasks/main.yml
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

test/integration/targets/gcp_compute_https_health_check/tasks/main.yml
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 12, 2019

Components

lib/ansible/modules/cloud/google/gcp_compute_global_forwarding_rule.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_http_health_check.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_http_health_check_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_https_health_check.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_https_health_check_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_instance.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

test/integration/targets/gcp_compute_global_forwarding_rule/tasks/main.yml
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

test/integration/targets/gcp_compute_http_health_check/tasks/main.yml
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

test/integration/targets/gcp_compute_https_health_check/tasks/main.yml
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): rambleraptor
shipit_actors_other: []
automerge: automerge tests passed

click here for bot help

1 similar comment
@ansibot
Copy link
Contributor

ansibot commented Aug 12, 2019

Components

lib/ansible/modules/cloud/google/gcp_compute_global_forwarding_rule.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_http_health_check.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_http_health_check_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_https_health_check.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_https_health_check_info.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

lib/ansible/modules/cloud/google/gcp_compute_instance.py
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

test/integration/targets/gcp_compute_global_forwarding_rule/tasks/main.yml
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

test/integration/targets/gcp_compute_http_health_check/tasks/main.yml
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

test/integration/targets/gcp_compute_https_health_check/tasks/main.yml
support: community
maintainers: erjohnso googlecloudplatform rambleraptor

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): rambleraptor
shipit_actors_other: []
automerge: automerge tests passed

click here for bot help

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 12, 2019
@ansibot ansibot merged commit 6cb5b67 into ansible:devel Aug 12, 2019
@ansible ansible locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud gce module This issue/PR relates to a module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@modular-magician @ansibot @rambleraptor