Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security group module #60187

Merged
merged 2 commits into from
Oct 19, 2019
Merged

Add security group module #60187

merged 2 commits into from
Oct 19, 2019

Conversation

zhongjun2
Copy link
Contributor

@zhongjun2 zhongjun2 commented Aug 7, 2019 •
edited

SUMMARY
Add a new modules hwc_vpc_security_group that can fetch huaweicloud Simple Message Notification.

COMPONENT NAME
lib/ansible/modules/cloud/huawei/hwc_vpc_security_group.py

ISSUE TYPE
New Module Pull Request

ANSIBLE VERSION
ansible 2.10

ADDITIONAL INFORMATION
I have tested the changes on the real environment.

@ansibot
Copy link
Contributor

ansibot commented Aug 7, 2019

cc @QijunPan @TommyLike @edisonxiang @freesky-edward @hwDCN @niuzhenguo @xuxiaowei0512 @zengchen1024
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cloud community_review In order to be merged, this PR must follow the community review workflow. huawei Huawei community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Aug 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 7, 2019

@QijunPan @TommyLike @edisonxiang @freesky-edward @huaweicloud @hwDCN @niuzhenguo @xuxiaowei0512 @zengchen1024

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@zengchen1024
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Aug 20, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 4, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/huawei/hwc_vpc_security_group.py:0:0: module-incorrect-version-added: version_added should be '2.10'. Currently '2.9'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. and removed shipit This PR is ready to be merged by Core ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 4, 2019
@zhongjun2
Copy link
Contributor Author

-label affects_2.9
+label affects_2.10

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed affects_2.9 This issue/PR affects Ansible v2.9 labels Oct 3, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 11, 2019
@niuzhenguo
Copy link

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 14, 2019
@zhongjun2
Copy link
Contributor Author

ready_for_review

resmo
resmo approved these changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@resmo resmo merged commit 7ed6a00 into ansible:devel Oct 19, 2019
@ansible ansible locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 cloud huawei Huawei community module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zhongjun2 @ansibot @zengchen1024 @niuzhenguo @resmo