Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add route module #60189

Merged
merged 9 commits into from
Oct 12, 2019
Merged

Add route module #60189

merged 9 commits into from
Oct 12, 2019

Conversation

zhongjun2
Copy link
Contributor

@zhongjun2 zhongjun2 commented Aug 7, 2019 •
edited

SUMMARY
Add a new modules hwc_vpc_route that can fetch huaweicloud Simple Message Notification.

COMPONENT NAME
lib/ansible/modules/cloud/huawei/hwc_vpc_route.py

ISSUE TYPE
New Module Pull Request

ANSIBLE VERSION
ansible 2.10

ADDITIONAL INFORMATION
I have tested the changes on the real environment.

@ansibot
Copy link
Contributor

ansibot commented Aug 7, 2019

cc @QijunPan @TommyLike @edisonxiang @freesky-edward @hwDCN @niuzhenguo @xuxiaowei0512 @zengchen1024
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cloud community_review In order to be merged, this PR must follow the community review workflow. huawei Huawei community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Aug 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 7, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/huawei/hwc_vpc_route.py:0:0: E324 Argument 'type' in argument_spec defines default as ('peering') but documentation defines default as (None)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 7, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 7, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/huawei/hwc_vpc_route.py:0:0: E319 RETURN.type.default: extra keys not allowed @ data['type']['default']. Got 'peering'

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 7, 2019

@QijunPan @TommyLike @edisonxiang @freesky-edward @huaweicloud @hwDCN @niuzhenguo @xuxiaowei0512 @zengchen1024

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 7, 2019
@zengchen1024
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Aug 20, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 4, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/huawei/hwc_vpc_route.py:0:0: module-incorrect-version-added: version_added should be '2.10'. Currently '2.9'

click here for bot help

@ansibot ansibot added the shipit This PR is ready to be merged by Core label Sep 10, 2019
@zhongjun2
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Sep 10, 2019

Components

lib/ansible/modules/cloud/huawei/hwc_vpc_route.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

test/integration/targets/hwc_vpc_route/aliases
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

test/integration/targets/hwc_vpc_route/tasks/main.yml
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): niuzhenguo zhongjun2
shipit_actors_other: []
automerge: automerge new_module test failed

click here for bot help

@zhongjun2
Copy link
Contributor Author

-label affects_2.9
+label affects_2.10

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 and removed affects_2.9 This issue/PR affects Ansible v2.9 labels Sep 26, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed shipit This PR is ready to be merged by Core labels Oct 8, 2019
@ansibot ansibot added the networking Network category label Oct 11, 2019
felixfontein
felixfontein reviewed Oct 12, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I only found a few language issues.

(Review based only on code, I didn't test anything.)

lib/ansible/modules/cloud/huawei/hwc_vpc_route.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/huawei/hwc_vpc_route.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/huawei/hwc_vpc_route.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/huawei/hwc_vpc_route.py Outdated Show resolved Hide resolved
felixfontein
felixfontein approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongjun2
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Oct 12, 2019

Components

lib/ansible/modules/cloud/huawei/hwc_vpc_route.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

test/integration/targets/hwc_vpc_route/aliases
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

test/integration/targets/hwc_vpc_route/tasks/main.yml
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): felixfontein zhongjun2
shipit_actors_other: []
automerge: automerge new_module test failed

click here for bot help

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 12, 2019
@felixfontein felixfontein merged commit 6170f3a into ansible:devel Oct 12, 2019
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 cloud huawei Huawei community module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zhongjun2 @ansibot @zengchen1024 @niuzhenguo @felixfontein