Move assertion in test_check_type_int unit test inside loop #60232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
samdoran
changed the title
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Aug 9, 2019
(cherry picked from commit aa71766) Co-authored-by: Sam Doran <sdoran@redhat.com>
abadger
pushed a commit
that referenced
this pull request
Aug 9, 2019
(cherry picked from commit aa71766) Co-authored-by: Sam Doran <sdoran@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the assertion only checks the output of the last loop iteration.
ISSUE TYPE
COMPONENT NAME
test/units/module_utils/common/validation/test_check_type_int.py