Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updating hosts idempotency in purefa_host #60367

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Fix updating hosts idempotency in purefa_host #60367

merged 1 commit into from
Aug 13, 2019

Conversation

sdodsley
Copy link
Contributor

@sdodsley sdodsley commented Aug 10, 2019 •
edited

SUMMARY

Changing host details does not show as a changed operation if the host already existing
and an update to the host occurred.
Also if host initiators details are given this always shows as a change even if they are the same.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

purefa_host.py

@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2019

cc @bannaych @genegr @lionmax @opslounge @raekins @sile16
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. pure_storage storage support:community This issue/PR relates to code supported by the Ansible community. labels Aug 10, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2019

cc @bannaych @genegr @lionmax @opslounge @raekins @sile16
click here for bot help

@sdodsley sdodsley mentioned this pull request Aug 13, 2019
Closed
genegr
genegr approved these changes Aug 13, 2019
View reviewed changes
Copy link

@genegr genegr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against Purity 5.2.5 and the reported misbehavior is not showing up anymore.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Aug 13, 2019
@ansibot ansibot merged commit 848c945 into ansible:devel Aug 13, 2019
@sdodsley sdodsley deleted the fa_host_fix branch August 15, 2019 21:45
@ansible ansible locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@genegr genegr genegr approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. has_issue module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. pure_storage shipit This PR is ready to be merged by Core storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sdodsley @ansibot @genegr