Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab_runners: update documentation of available choices for plugin #60370

Merged
merged 1 commit into from
Aug 12, 2019
Merged

gitlab_runners: update documentation of available choices for plugin #60370

merged 1 commit into from
Aug 12, 2019

Conversation

kapsh
Copy link
Contributor

@kapsh kapsh commented Aug 10, 2019

SUMMARY

Fix choices formatting in plugin option.

ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

COMPONENT NAME

gitlab_runner

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Aug 10, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/inventory/gitlab_runners.py:30:21: W291 trailing whitespace

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 10, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/inventory/gitlab_runners.py:30:21: W291 trailing whitespace

click here for bot help

@kapsh
gitlab_runners
4e65c4d 
##### SUMMARY
Fix choices formatting in plugin option.

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 10, 2019
resmo
resmo approved these changes Aug 11, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akasurde Akasurde changed the title gitlab_runners gitlab_runners: update documentation of available choices for plugin Aug 12, 2019
@acozine acozine removed the needs_triage Needs a first human triage before being processed. label Aug 12, 2019
@acozine acozine merged commit 273a2d7 into ansible:devel Aug 12, 2019
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Sep 5, 2019
@ansible ansible locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kapsh @ansibot @resmo @dagwieers @acozine