Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [iosxr_lldp_interfaces] resource module #60411

Merged
merged 1 commit into from Aug 13, 2019
Merged

Add [iosxr_lldp_interfaces] resource module #60411

merged 1 commit into from Aug 13, 2019

Conversation

NilashishC
Copy link
Contributor

@NilashishC NilashishC commented Aug 12, 2019 •
edited

Signed-off-by: NilashishC nilashishchakraborty8@gmail.com
Depends-On: #59153

SUMMARY
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

iosxr_lldp_interfaces.py

@NilashishC NilashishC changed the title Add iosxr_lldp_interfaces resource module Add [iosxr_lldp_interfaces] resource module Aug 12, 2019
@NilashishC NilashishC added this to Module in Development in Ansible 2.9 Networking Feature Dev Aug 12, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 12, 2019

cc @Qalthos @danielmellado @ganeshrn @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community iosxr Cisco IOSXR community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Aug 12, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 12, 2019

cc @Qalthos @danielmellado @ganeshrn @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansible-zuul

This comment has been minimized.

Sign in to view
@NilashishC
Add iosxr_lldp_interfaces resource module
6718a41 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC NilashishC marked this pull request as ready for review August 12, 2019 16:34
@NilashishC NilashishC moved this from Module in Development to Module in Review in Ansible 2.9 Networking Feature Dev Aug 12, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 12, 2019

cc @NilashishC
click here for bot help

@ansibot ansibot added the test This PR relates to tests. label Aug 12, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 12, 2019

cc @NilashishC
click here for bot help

@NilashishC
Copy link
Contributor Author

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Aug 12, 2019

This change depends on a change that failed to merge.

@ansible-zuul
Copy link

ansible-zuul bot commented Aug 12, 2019

Build succeeded (third-party-check pipeline).

@ikhan2010
Copy link

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Aug 12, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 12, 2019
@NilashishC
Copy link
Contributor Author

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Aug 13, 2019

Build succeeded (third-party-check pipeline).

danielmellado
danielmellado approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@danielmellado danielmellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @NilashishC. Thanks!

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 13, 2019
@NilashishC NilashishC merged commit 6110dcc into ansible:devel Aug 13, 2019
@NilashishC NilashishC deleted the iosxr_lldp_interfaces branch August 13, 2019 09:29
@NilashishC NilashishC moved this from Module in Review to Module Completed in Ansible 2.9 Networking Feature Dev Aug 13, 2019
@ansible ansible locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielmellado danielmellado danielmellado approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies ios Cisco IOS community iosxr Cisco IOSXR community module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
Ansible 2.9 Networking Feature Dev
  
Module Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NilashishC @ansibot @ikhan2010 @danielmellado